Menu ▾ ▴

Obsolete (git) Merge Request #20: ID:497 Raw command to allow responses larger than 256 bytes (rejected)

Merging...

Merged

Something went wrong. Please, merge manually

Checking if merge is possible...

Something went wrong. Please, merge manually

Vernon Mauery wants to merge 1 commit from /u/vmauery11/ipmitool/ to master, 2018-04-05

Take a more nuanced approach. Remove the fixed-sized buffer from ipmi_rs and replace it in the various instances with a pointer to a buffer that is sized appropriately for that interface's max transfer size.

Commit Date  
[e842fc] (id_497_raw_command_buffer_size_v2) by Vernon Mauery Vernon Mauery

ID:497 Raw command to allow responses larger than 256 bytes

All the interfaces use a static struct ipmi_rs to capture a response.
The struct has an embedded buffer that is a fixed size for all
interfaces, regardless of the interface's max transfer size. Bumping up
the buffer size to the maximum of all transfer sizes would increase
memory usage by too much, so this change sets a static buffer for each
of the interfaces that is the right size for that interface.

This does increase the BSS slightly, but only by ~57kB (in my build).

Closes:
ID:497 https://sourceforge.net/p/ipmitool/bugs/497/

Signed-off-by: Vernon Mauery <vernon.mauery@...>

 2018-04-03 21:26:38 Tree

Discussion

  • Vernon Mauery

    Vernon Mauery - 2018-04-05

    the first one came back with a server error, so I tried to submit again, only to find now I had two requests. get it together, sourceforge.

     

  • Vernon Mauery

    Vernon Mauery - 2018-04-05
    • Status: open --> rejected
     

Log in to post a comment.