#26 ipmievd - Add event direction output to syslog

[Kipp Glover]

With the current implementation of ipmievd, some events are misleading to read in the syslog, because the direction (assertion deassertion) are not printed to the syslog.

For example, if you remove a power supply and reinsert it, the information printed to the syslog will look the same for both events. If you look at the SEL in more detail (ipmitool -v sel list) you can see that the first event was an assertion event and the second was a deassertion event.

To make the ipmievd syslog entries more readable, I have created a patch (ipmievd.c log_event() function) that will print out the event direction for other non-sensor specific events (!= 0x6f).

Cheers!
/Kipp

[Kipp Glover]

ipmievd.c patch to print event direction

[Carol Hebert]

Hi,
Thanks for bringing up this issue and for working on a patch. I took a look at the patch but I think it still needs some work. The first hunk will make the "else" portion of the "if-else" identical to the "if" portion. It also will print a Desasserted/Asserted string for all event types includeing THRESHOLD and OEM types. Maybe what needs to happen there is more like what's there for the FULL SENSOR type (isolating the discrete types for special print treatment). The second hunk of the patch will print Deasserted/Asserted strings for all record types beyond FULL and COMPACT sensor types indiscriminantly. Maybe what needs to be there instead is another case for EVENT ONLY, etc. sensors?
Also, it's probably best to remove old lines rather than to comment them out unless there's a good reason for leaving them there (i.e., it helps future developers understand the code/history/reason for a change). Having extra lines/comments in the code makes it less readable.
Anyway, that's my $.02. Thanks again for your interest in and support of ipmitool :)
Carol Hebert