From: Zdenek S. <st...@us...> - 2013-03-29 14:53:02
|
Update of /cvsroot/ipmitool/ipmitool/lib In directory sfp-cvs-1.v30.ch3.sourceforge.com:/tmp/cvs-serv28972/lib Modified Files: ipmi_fru.c Log Message: ID: 3600911 - 'lib/ipmi_fru.c' - fix multiple increments in args to printf Commit fixes multiple increments in arguments of printf() which leads to undefined/inconsistent behaviour and results. Reported-by: Ales Ledvinka Index: ipmi_fru.c =================================================================== RCS file: /cvsroot/ipmitool/ipmitool/lib/ipmi_fru.c,v retrieving revision 1.75 retrieving revision 1.76 diff -C2 -d -r1.75 -r1.76 *** ipmi_fru.c 29 Mar 2013 14:40:21 -0000 1.75 --- ipmi_fru.c 29 Mar 2013 14:52:59 -0000 1.76 *************** *** 2237,2241 **** for (i=0; i<entries; i++) { printf(" HWAddr: 0x%02x - SiteNum: 0x%02x - SiteType: 0x%02x \n", ! fru_data[offset++], fru_data[offset++], fru_data[offset++]); } } --- 2237,2242 ---- for (i=0; i<entries; i++) { printf(" HWAddr: 0x%02x - SiteNum: 0x%02x - SiteType: 0x%02x \n", ! fru_data[offset], fru_data[offset+1], fru_data[offset+2]); ! offset+= 3; } } |