From: Bernard Manjou <bernard.manjou@bu...> - 2008-06-17 13:53:34
This mail is a complement to the mail titled "PATCH proposal for
Sensors owned by satellite controlers" sent on 06/10/08.
Sensors with same "sensor numbers" (or "sensor ID string") but
with different "owner ID slave address" are not correctly
managed by "ipmitool sdr get sensor_id", "ipmitool sensor ..."
commands with sensorid argument, ipmi_event_fromsensor() routine,
and "ipmitool sunoem ..."commands with the sensorid argument.
The reason is that ipmi_sdr_find_sdr_byid() looks for SDR entry
matching the "sensor ID string" whereas it should also match the
"I2c slave address" of the sensor owner.
Similarly, FRUs with same "FRU device IDs" (or "FRU device string")
but with different "device access address" are not correctly managed
by "ipmitool fru ..." commands with fru_id argument.
If you agree with this analysis, my feeling is that an optional
argument (ie:called "owner_id"), set by default to 0x20, should be
added to ipmitool commands with fru_id or sensor_id argument, and
this "owner_id" parameter should be added to ipmi_sdr_find_sdr_byid()
and to all calling routines.
System Software Development R&D
phone : +33 (0) 1 30 80 73 50
Bull, Architect of an Open World TM
Rue Jaures, BP 68, 78340 Les Clayes-sous-Bois, France