#42 Improve help message for 'ipmitool picmg policy set'

version-cvs
closed
None
5
2014-09-09
2013-08-06
Dan Gora
No

A quick patch to improve the help message for ipmitool picmg policy set. The previous help message was basically just copied out of the AMC specifications describing the bit fields in the message, but it was really unclear how the command itself worked without looking at the source code and the AMC specification. It now tries to make it clear that the values in square brackets are bit positions and not values.

thanks
dan

Index: lib/ipmi_picmg.c

RCS file: /cvsroot/ipmitool/ipmitool/lib/ipmi_picmg.c,v
retrieving revision 1.26

diff -u -r1.26 ipmi_picmg.c
--- lib/ipmi_picmg.c 18 May 2013 06:31:02 -0000 1.26
+++ lib/ipmi_picmg.c 6 Aug 2013 21:22:21 -0000
@@ -1858,12 +1858,13 @@
} else {
lprintf(LOG_NOTICE, "usage: set <fruid> <lockmask> <lock>");
lprintf(LOG_NOTICE,
- " lockmask: [1] affect the deactivation locked bit");
+ " lockmask: [bit 1] Set to 1 to affect the deactivation locked bit");
lprintf(LOG_NOTICE,
- " [0] affect the activation locked bit");
+ " [bit 0] Set to 1 to affect the activation locked bit");
lprintf(LOG_NOTICE,
- " lock: [1] set/clear deactivation locked");
- lprintf(LOG_NOTICE, " [0] set/clear locked");
+ " lock: [bit 1] Set to 1 to set, 0 to clear deactivation locked");
+ lprintf(LOG_NOTICE,
+ " [bit 0] Set to 1 to set, 0 to clear activation locked");
}
}
else {

Discussion

  • Zdenek Styblik

    Zdenek Styblik - 2013-08-23

    Ticket moved from /p/ipmitool/patches/74/

     
  • Zdenek Styblik

    Zdenek Styblik - 2013-08-23

    I'm sorry to say, but changed help doesn't make any sense to me.

     
  • Zdenek Styblik

    Zdenek Styblik - 2013-08-23
    • Description has changed:

    Diff:

    --- old
    +++ new
    @@ -1,4 +1,3 @@
    -
     A quick patch to improve the help message for ipmitool picmg policy set.  The previous help message was basically just copied out of the AMC specifications describing the bit fields in the message, but it was really unclear how the command itself worked without looking at the source code and the AMC specification.  It now tries to make it clear that the values in square brackets are bit positions and not values.
    
     thanks
    
    • Group: version-1.8.13 --> version-1.8.14
     
  • Zdenek Styblik

    Zdenek Styblik - 2014-05-14
    • status: open --> pending
    • Group: version-1.8.14 --> version-cvs
     
  • Zdenek Styblik

    Zdenek Styblik - 2014-09-09

    No progress. Closing. Open a new bug if you want to. Thanks.

     
  • Zdenek Styblik

    Zdenek Styblik - 2014-09-09
    • status: pending --> closed
    • assigned_to: Zdenek Styblik
     

Log in to post a comment.