#99 'lib/ipmi_sel.c' - possible int *flow

version-1.8.13
closed-fixed
None
5
2013-08-23
2012-05-20
No

Following should be replaced with appropriate function from 'lib/helper.c' and errors handled.

rqdata\[j\] = \(uint8\_t\)strtol\(tok, NULL, 0\);
tok = strtok\(NULL, " "\);
strtol\(\(const char\*\)cursor, \(char \*\*\)NULL,16\);
strtol\(\(const char\*\)cursor, \(char \*\*\)NULL,16\);
strtol\(\(const char\*\)cursor, \(char \*\*\)NULL,10\);
strtol\(\(const char\*\)cursor, \(char \*\*\)NULL,16\);
strtol\(cursor, \(char \*\*\)NULL,10\);
strtol\(cursor, \(char \*\*\)NULL,10\);
0xA0 | strtol\(cursor, \(char \*\*\)NULL,10\) ;
\(strtol\(cursor, \(char \*\*\)NULL,16\)\)<<4 ; 
strtol\(\(const char\*\)cursor, \(char \*\*\)NULL,16\);
strtol\(\(const char\*\)cursor, \(char \*\*\)NULL,16\);
strtol\(\(const char\*\)cursor, \(char \*\*\)NULL,16\);
id = \(uint16\_t\) strtoul\(argv\[argc-1\], NULL, 0\);
id = \(uint16\_t\)strtol\(argv\[i\], NULL, 0\);
\*value = strtol\(str,&tmp,0\);

Discussion

  • Zdenek Styblik

    Zdenek Styblik - 2013-03-14

    Look for atol() as well.

     
  • Zdenek Styblik

    Zdenek Styblik - 2013-03-30
    • milestone: --> version-1.8.12
     
  • Zdenek Styblik

    Zdenek Styblik - 2013-08-16
    • status: open --> open-accepted
    • assigned_to: Zdenek Styblik
     
  • Zdenek Styblik

    Zdenek Styblik - 2013-08-23
    • status: open-accepted --> closed-fixed
     
  • Zdenek Styblik

    Zdenek Styblik - 2013-08-23

    Committed into CVS.

     

Log in to post a comment.