#464 ipmievd crash when logging event data

[Marcin Bernatowicz]

Unrecognized sdr->type case causes core dump in log_event.c line 336:

            #0  0x00007fc9454d338f vfprintf (libc.so.6)
            #1  0x00007fc9454fe0c9 vsnprintf (libc.so.6)
            #2  0x000000000042442f lprintf (ipmievd)
            #3  0x0000000000403846 log_event (ipmievd)
            #4  0x0000000000404267 selwatch_read (ipmievd)
            #5  0x00000000004042fc selwatch_wait (ipmievd)
            #6  0x00000000004049c5 ipmievd_main (ipmievd)
            #7  0x0000000000404aa9 ipmievd_sel_main (ipmievd)
            #8  0x0000000000428af0 ipmi_cmd_run (ipmievd)
            #9  0x000000000042ab26 ipmi_main (ipmievd)
            #10 0x0000000000404b7c main (ipmievd)
            #11 0x00007fc9454a7580 __libc_start_main (libc.so.6)
            #12 0x0000000000403079 _start (ipmievd)

The mentioned line is missing format parameter for sensor_num:

default:
        lprintf(LOG_NOTICE, "%s%s sensor - %s",
            eintf->prefix, type,
            evt->sel_type.standard_type.sensor_num, desc ? desc : "");
        break;

    should be:

default:
        lprintf(LOG_NOTICE, "%s%s sensor (0x%02x) - %s",
            eintf->prefix, type,
            evt->sel_type.standard_type.sensor_num, desc ? desc : "");
        break;

[Marcin Bernatowicz]

patch attached

[Zdenek Styblik]

Nice and rather unfortunate catch. Thanks.

Z.