#459 ipmitool 1.8.16 failure to download shelf fru

[Dmitry Rakhchev]

The ipmitool now fails to download the FRU on the Artesyn (Emerson) shelf manager, MF105.

ipmitool -I lan -A none -H "shmm" fru print 1
FRU Read failed: Request data length invalid
FRU Read failed: Request data length invalid
FRU Read failed: Request data length invalid

Apparently commit visible as c7412e58 removed handling of 0xC7(Request data length invalid) as indication that requested data length is too big.

Offending change happens after 1.8.13.

[Dmitry Rakhchev]

Note, that in two other cases 0xC7 is still leading to decrease of requested data size. Make all cases identical, see attached patch.

[Zdenek Styblik]

:\ FRU module is, well, crap. btw patch doesn't compile due to the redundant/trailing &&, me thinks, resp. when removed, it does compile. However, I'm not sure whether that's a typo/bug or was some other intention.

Z.

[Dmitry Rakhchev]

I've talked with Dmitry (author of the c7412e58). We come to an agreement that 0xC7 is definitely not the way to reject Read FRU Data with too much bytes requested, but

• there is this (old) IPMC from Artesyn/Emerson that behave this way and it is unlikely to be fixed
• if we handle 0xC7 this way, for IPMC that has other (not the requested number of bytes) reason for this error, we only retry the command several times, no harm except for longer execution time before failing with error.
• for old IPMCs that use 0xC7 to report too much bytes requested the code will work by adjusting requested number of bytes.

So the patch will not cause havoc for IPMC that behave, and allow ipmitool to talk to old misbehaving ones.

I've fixed the patch by removing extra "&&".

[Zdenek Styblik]

It is in. Thanks.

Z.