#454 Add support for PICMG 3.1 R2.0 Link Types and Link Classes.

[Dan Gora]

Hi All,

The attached patch adds support for decoding new 10Gbps link classes introduced in PICMG 3.1 R2.0.

============================================
PICMG 3.1 R2.0 introduces new a new Link Class field in the FRU
Link Descriptors which is the upper 4 bits of the Link Type field.
This new Link Class field specifies SERDES lanes with 10.3125Gbd
signalling rate.

It also introduces the new Base-KX and Base-KX4 types which are the
new IEEE replacements for the PICMG 3.0 Base-BX and Base-BX4 types.

This patch decodes these new types and fields and will print out
proper descriptions for each one based on PICMG 3.1 R2.0

[Dan Gora]

Hi Zdenek,

I read this document, but I still don't see what is wrong. It's
indented exactly the same as all of the rest of the code there.

Can you give me some clue as to what is wrong?

thanks
dan

On Sun, Aug 7, 2016 at 7:26 AM, Zdenek Styblik stybla@users.sf.net wrote:

status: open --> pending
Comment:

Hello,

please, read https://sourceforge.net/p/ipmitool/wiki/Coding%20Standards/.

Thanks,
Z.

[Zdenek Styblik]

Hello Dan,

please, don't put else, else if, switch and { and } on extra lines.

Thanks,
Z.

[Dan Gora]

Hi Zdenek,

The code is formatted exactly like it was before, except that I did
pull up a { on one of the switch statements:

• switch (d->type)

• {

• switch (d->type) {

As far as the if/else clauses, I literally cut this code:

• if (d->type == 0 || d->type == 0xff) {
• printf("Reserved\n");
• }
• else if (d->type >= 0x06 && d->type <= 0xef) {
• printf("Reserved\n");
• }
• else if (d->type >= 0xf0 && d->type <= 0xfe) {
• printf("OEM GUID Definition\n");
• }

and moved it to a different spot... I didn't change the formatting at all.

• if (d->type == 0 ||
  d->type == 0xff) {
• printf("Reserved\n");
• }
• else if (d->type >=
  0x06 && d->type <= 0xef) {
• printf("Reserved\n");
• }
• else if (d->type >=
  0xf0 && d->type <= 0xfe) {
• printf("OEM
  GUID Definition\n");
• }

How about we just add this functionality patch, then do another to fix
the code formatting separately since all of the code in this file
would have to be changed.. Would that be acceptable?

thanks
dan

On Wed, Aug 17, 2016 at 5:21 PM, Zdenek Styblik stybla@users.sf.net wrote:

Hello Dan,

please, don't put else, else if, switch and { and } on extra lines.

Thanks,
Z.

[Zdenek Styblik]

Hello,

please, read https://sourceforge.net/p/ipmitool/wiki/Coding%20Standards/.

Thanks,
Z.

[Dan Gora]

Hi Zdenek,

Never mind.. I don't want to waste any more energy on code formatting arguments.. Here is a patch which hopefully has the formatting the way you like it..

thanks
dan

[Zdenek Styblik]

Great. Thanks!

How about we just add this functionality patch, then do another to fix
the code formatting separately since all of the code in this file
would have to be changed.. Would that be acceptable?

Yes, that's actually preferred way.

Z.