Menu

#453 Limit request sizes for the openIPMI interface to 37 bytes instead of 38.

version-cvs
closed-wont-fix
None
5
2016-08-17
2016-08-01
Dan Gora
No

Hi All,

This patch is a fix for updating the hpm1 firmware via the 'ipmitool hpm upgrade' command over the KCS interface to a IPMC running the PPS IPMI code:

If there are any questions or comments, please let me know.

thanks
dan

=====================================
Limit request sizes for the openIPMI interface to 37 bytes instead of 38.

The Pigeon Point Systems IPMI code only supports a maximum payload
data size of 37 bytes over the payload serial, KCS, SMB and LAN
interfaces, so we need to limit the maximum request size to 37 bytes
in the openIPMI plugin to prevent the KCS interface from overflowing
and stalling when HPM1 upgrades are performed.

1 Attachments

Related

Bugs (use GitHub instead): #453

Discussion

  • Zdenek Styblik

    Zdenek Styblik - 2016-08-07

    Shouldn't this be based on OEM Vendor ID? It seems to me like this is a PPS specific change.

    Thanks,
    Z.

     
  • Dmitry Rakhchev

    Dmitry Rakhchev - 2016-08-15

    IPMI requires 38 bytes, so I think this shall be fixed in the IPMC. Also using "-z 37" on the command line shall give the same effect and can be used as a workaround.

     
    • Dan Gora

      Dan Gora - 2016-08-15

      Hi Dmitry,

      Thanks.. I looked but I could not find where this was specified so I
      assumed that PPS knew what they were doing... It would be nice for
      this to work for boards already in the field, but since there is
      already a command line workaround, that should be fine.

      I'll withdraw this patch.

      thanks again,
      dan

      On Mon, Aug 15, 2016 at 7:48 AM, Dmitry Rakhchev
      rdaemcraft@users.sf.net wrote:

      IPMI requires 38 bytes, so I think this shall be fixed in the IPMC. Also
      using "-z 37" on the command line shall give the same effect and can be used
      as a workaround.


      [bugs:#453] Limit request sizes for the openIPMI interface to 37 bytes
      instead of 38.

      Status: open
      Group: version-cvs
      Created: Mon Aug 01, 2016 08:46 PM UTC by Dan Gora
      Last Updated: Sun Aug 07, 2016 10:27 AM UTC
      Owner: nobody
      Attachments:

      ipmi1.txt (1.4 kB; text/plain)

      Hi All,

      This patch is a fix for updating the hpm1 firmware via the 'ipmitool hpm
      upgrade' command over the KCS interface to a IPMC running the PPS IPMI code:

      If there are any questions or comments, please let me know.

      thanks
      dan

      =====================================
      Limit request sizes for the openIPMI interface to 37 bytes instead of 38.

      The Pigeon Point Systems IPMI code only supports a maximum payload
      data size of 37 bytes over the payload serial, KCS, SMB and LAN
      interfaces, so we need to limit the maximum request size to 37 bytes
      in the openIPMI plugin to prevent the KCS interface from overflowing
      and stalling when HPM1 upgrades are performed.

       

      Related

      Bugs (use GitHub instead): #453

  • Zdenek Styblik

    Zdenek Styblik - 2016-08-17
    • status: open --> closed-wont-fix
    • assigned_to: Zdenek Styblik
     
  • Zdenek Styblik

    Zdenek Styblik - 2016-08-17

    Alright, closing the ticket then. Thanks.
    Z.

     

Log in to post a comment.