#419 Dummy interface fails to compile

[Hinko Kocevar]

Dummy interface fails to compile due to missing dummy.h:

make[4]: Entering directory `/home/hinxx/Downloads/ipmitool-1.8.16/src/plugins/dummy'
/bin/bash ../../../libtool --silent  --tag=CC   --mode=compile gcc -DHAVE_CONFIG_H -I. -I../../.. -I../../../include    -g -O2 -Wall -Wextra -std=c99 -pedantic -Wformat -Wformat-nonliteral -MT dummy.lo -MD -MP -MF .deps/dummy.Tpo -c -o dummy.lo dummy.c
In file included from dummy.c:39:0:
../../../include/ipmitool/ipmi.h:73:3: warning: type of bit-field 'netfn' is a GCC extension [-Wpedantic]
   uint8_t netfn:6;
   ^
../../../include/ipmitool/ipmi.h:74:3: warning: type of bit-field 'lun' is a GCC extension [-Wpedantic]
   uint8_t lun:2;
   ^
dummy.c:44:19: fatal error: dummy.h: No such file or directory
 #include "dummy.h"
                   ^
compilation terminated.
make[4]: *** [dummy.lo] Error 1
make[4]: Leaving directory `/home/hinxx/Downloads/ipmitool-1.8.16/src/plugins/dummy'
make[3]: *** [all-recursive] Error 1
make[3]: Leaving directory `/home/hinxx/Downloads/ipmitool-1.8.16/src/plugins'
make[2]: *** [all-recursive] Error 1
make[2]: Leaving directory `/home/hinxx/Downloads/ipmitool-1.8.16/src'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/home/hinxx/Downloads/ipmitool-1.8.16'
make: *** [all] Error 2

Could dummy interface be used to solve https://sourceforge.net/p/ipmitool/bugs/322/ ?

[Zdenek Styblik]

Are you sure? Because dummy.h is in git and in the place where it's supposed to be. I can check tomorrow, but it used to compile just fine.

Could dummy interface be used to solve https://sourceforge.net/p/ipmitool/bugs/322/ ?

Unfortunately, the way IPMI tool has been designed, no. Interface is being opened in main and commands sent even before it gets to the "module". :\

[Zdenek Styblik]

... but dummy.h isn't in a tarball.

[Hinko Kocevar]

I have not used GIT, but 1.8.16 tarball. Folder ipmitool-1.8.16/src/plugins/dummy/ lacks dummy.h.

[Jim Mankovich]

The Makefile.am template for the dummy plugin does not identify that dummy.h is needed so it doesn't end up in the tarball.

[Zdenek Styblik]

Nor do many other interfaces.

EDIT: ok, they don't have header files. But I still don't follow why header files wouldn't be shipped in tarball.

[Zdenek Styblik]

I've added it to Makefile.am. It should be fixed in v1.8.17 then.

Thank you for the report.