USB interface fails to build under Windows/Cygwin. Instead of manually disabling it via configure parameter, disable it by default unde Windows/Cygwin.
This doesn't look right. If I understand it correctly, it removes the default value. Isn't setting it to 'no' under 'cygwin' enough? Also, help text doesn't reflect this change.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
The default value is "yes", see line #62 of the configure.ac.
I just make it "no" by default for Cygwin, and don't enable it, if "--enable-intf-usb" is not specified.
So, the patch is correct, unless there are more arguments to consider.
Regards,
Dmitry
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Dmitry, let me rephrase. There are two parts of the patch. The first part,
setting default value for Cygwin, I agree with. The second part, I don't,
because I think it is unnecessary and might break things.
The default value is "yes", see line #62 of the configure.ac.
I just make it "no" by default for Cygwin, and don't enable it, if
"--enable-intf-usb" is not specified.
So, the patch is correct, unless there are more arguments to consider.
Status: open Group: version-1.8.17 Created: Mon Jan 18, 2016 07:43 AM UTC by Dmitry Bazhenov Last Updated: Tue Jan 19, 2016 07:31 PM UTC Owner: nobody
USB interface fails to build under Windows/Cygwin. Instead of manually
disabling it via configure parameter, disable it by default unde
Windows/Cygwin.
Zdenek, I understand your concern. But, it is indeed necessary, because otherwise, when the parameter is omitted, the USB driver will be enabled disregarding the default value.
So, the second part of my patch removes this redundant "enable".
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Patch for the bug.
This doesn't look right. If I understand it correctly, it removes the default value. Isn't setting it to 'no' under 'cygwin' enough? Also, help text doesn't reflect this change.
Hello, Zdenek,
The default value is "yes", see line #62 of the configure.ac.
I just make it "no" by default for Cygwin, and don't enable it, if "--enable-intf-usb" is not specified.
So, the patch is correct, unless there are more arguments to consider.
Regards,
Dmitry
Dmitry, let me rephrase. There are two parts of the patch. The first part,
setting default value for Cygwin, I agree with. The second part, I don't,
because I think it is unnecessary and might break things.
Z.
On 20 Jan 2016 4:59 am, "Dmitry Bazhenov" dbazhenov@users.sf.net wrote:
Related
Bugs (use GitHub instead):
#410Zdenek, I understand your concern. But, it is indeed necessary, because otherwise, when the parameter is omitted, the USB driver will be enabled disregarding the default value.
So, the second part of my patch removes this redundant "enable".
Hello Dmitry,
attached is a patch that should address the second part of the problem. Please, give it a try.
Thanks.
Will try. Should work I think.
Done. Works on Cygwin64 and Linux x86_64 as appropriate.
Great! I'll merge these two patches then, resp. will apply appropriate parts, and give it a commit later.
Committed to git. Thanks.