Menu

#350 Prevent buffer overflow with large ID strings

None
open
nobody
None
5
2014-12-20
2010-05-21
No

When IPMI records have ID strings larger than 16 bytes, we have to make sure we only read 16 bytes, because the structures used only have room for that many bytes, and so does the desc buffer.

Note: I made the changes minimal because I am not familiar with the code. But I am really curious why the structures only reserve only 16 bytes for id_string when the IPMI specification says the maximum valid length is 30.

Discussion

  • Jean Delvare

    Jean Delvare - 2010-05-21

    Proposed fix

     
  • Zdenek Styblik

    Zdenek Styblik - 2014-12-20

    Ticket moved from /p/ipmitool/patches/40/

     

Log in to post a comment.

MongoDB Logo MongoDB