Menu

#215 fru unsigned errors

version-cvs
open
nobody
None
5
2013-07-08
2013-03-14
No

size can't be negative - dead code

the the "-" result in the unsigned storage is never negative

Discussion

  • Ales Ledvinka

    Ales Ledvinka - 2013-03-14

    unsigned errors

     
  • Zdenek Styblik

    Zdenek Styblik - 2013-03-21

    I'm wondering where were you when code review was up.

     
  • Zdenek Styblik

    Zdenek Styblik - 2013-03-21

    What is the second part of the diff about?

     
  • Zdenek Styblik

    Zdenek Styblik - 2013-03-21

    I've removed 'size' check. I don't know what's the second part about.

     
  • Zdenek Styblik

    Zdenek Styblik - 2013-03-21
    • assigned_to: nobody --> stybla
    • status: open --> open-accepted
     
  • Ales Ledvinka

    Ales Ledvinka - 2013-03-22

    stybla: saw the other review pending so I did not pay too much attention and overlooked that.

    second part should be about "- remaining_offset" underflow on unsigned operation.

     
  • Zdenek Styblik

    Zdenek Styblik - 2013-07-08
    • status: open-accepted --> open
    • assigned_to: Zdenek Styblik --> nobody
     
  • Zdenek Styblik

    Zdenek Styblik - 2013-07-08

    later.

     

Log in to post a comment.

MongoDB Logo MongoDB