New home found
GitHub project going orphan
ipmitool doesn't validate parameters completely
Fixed on GitHub, see https://github.com/ipmitool/ipmitool/issues/104
https://sourceforge.net/p/ipmitool/bugs/291/
Resolved in github.com/ipmitool/ipmitool/issues/25
Hi Kipp. As a new maintainer of ipmitool I've been browsing through code and found commit [4787c3] that contains this patch. It looks to me like you fixed a bug in your BMC here, not in ipmitool. If you open IPMI Specification 2.0 rev 1.1, section 20.8 (Get Device GUID Command), you'll see that it says the following: "Note that the individual fields within the GUID are stored least-significant byte first, and in the order illustrated in the following table. This is the reverse of convention described...
Can't get data of Node Manager Policy ID 255
The patch has been just merged into master on github. Next time please use the issue system there. Do you have an account?
Ok, I've reproduced it. It's because of this ingenious piece of code: (gdb) bt #0 __memmove_avx_unaligned () at ../sysdeps/x86_64/multiarch/memcpy-avx-unaligned.S:357 #1 0x000000000048f3c3 in ipmi_lan_poll_single (intf=0x7680c0 <ipmi_lanplus_intf>) at lanplus.c:878 #2 0x000000000048f434 in ipmi_lan_poll_recv (intf=0x7680c0 <ipmi_lanplus_intf>) at lanplus.c:913 #3 0x000000000049251d in ipmi_lanplus_recv_sol (intf=0x7680c0 <ipmi_lanplus_intf>) at lanplus.c:2693 #4 0x000000000041d3bb in ipmi_sol_red_pill...
Sorry, the core file is not enough. Please also attach the unstripped src/ipmitool binary that you got that core on. Otherwise it is impossible to correctly map the core to actual symbols.
Hi Alexander Thanks for the reply. I don't think it is duplicate , Since in my reported issue the ipmi tool should not send the bridging command when sensor owner bit is enable. But in the other case #502 issue it should do the bridging since the sensor owner bit is not set. Thanks Ravi Sastry S
Development moved to GitHub
Getting error "Unable to send command: Invalid argument" in open ipmi interface.
Looks duplicated by [#502]
Looks duplicated by #502
Yes, to speed up output is not affect on service processor itself. Due to we use ipmitool to do service process discovery, collect info and add to our manage list if target is communicable. In our test example, one target reduce 13s, 100 targets will reduce 21 min waitting time. To reduce waitting time for not communicable target is really help performance improvement.
The patch resolve all related problems. Thanks for your fix. About your remind, next time I will attach patch file if new issue occur.
Hi, Mr. Amelkin: I checked out master branch and re-generate diff file. Please check my diff file is OK or not. I will also try "Pull Request" to request merge code. Thank you
If it works for you, then I'll merge it into master.
Elaine Li, please take a look at the attached patch (also available in bugfix/509 branch that sourceforge refuses to display in web interface).
Run Node Manager some commands will cause Segmentation fault.
ID:497 Raw command to allow responses larger than 256 bytes
the first one came back with a server error, so I tried to submit again, only to find now I had two requests. get it together, sourceforge.
ID:497 Raw command to allow responses larger than 256 bytes
ID:497 Raw command to allow responses larger than 256 bytes
Fix for ID:497 - long response crashes raw command
Can't get data of Node Manager Policy ID 255
Can't get data of Node Manager Policy ID 255
Please next time do not copy-paste patches. Besides, your patch is incomplete. However, I got the idea and will fix that.
Can't get sensor reading using sdr command via a bridge
Will look into it. Unfortunately, I don't have any bridged system at hand to debug. If you can investigate and debug it yourself, a patch or a pull request are welcome.
Run Node Manager some commands will cause Segmentation fault.
This has been fixed with [6d9c54]. Next time please do not copy-paste patches (they get broken). Attach them or create pull requests.
ID:508 - Fix segfaults in dcmi command handlers
long response crashes raw command
See my comments to [ipmitool/source/merge-requests/18]
Add Quanta OEM code: ipmitool for DIMM slot readable feature
ipmitool doesn't validate parameters completely
There are lots of places where strncmp() is used with n argument calculated via __maxlen macro that calls strlen(). This per se looks useless to me and defeats the possible purpose of using strncmp(). However in lib/ipmi-mc.c that macro is not used, hence your problem. I think that strncmp() and __maxlen() must be replaced in most places with just strcmp(). That will also get rid of warnings related to __maxlen() macro definition. When I have time, I'll look into it.
Fix for Issue 374 - PICMG LED SET parameter checking too fierce
Rejecting as per discussion in [#374]
Bug 374 - Relax validation of LED Duration
Rejecting as per discussion in [#374]
Bug 374 - Slightly relax validation of LED Duration
Rejecting as per discussion in [#374]
IPMI_BUF_SIZE is used in a lot of places. Increasing it to 64K will result in static allocation of 512K in ipmi_tsol.c, for example. It looks to me like a more thorough refactoring of the code is required. For instance, I'd go with dynamic allocation of the buffers (not just here, but everywhere) and would base their sizes on the maximum possible value for the relevant structure field size, using something like #define MAX_VAL(t) ((typeof(t))(~((typeof(t))0))) For the code in question that would...
ipmi sensor output incorrect
Looks like this has been fixed (by zeroing of the response buffer) back in 2012 by Jim Mankovich with commit [5d9600]. Closing.
Your patch is not based on latest master branch and contains extra changes that are already on master. Please rebase and send a new patch, or better yet fork and create a pull request. Pull requests are easier to review and comment than patches attached to tickets.
Hi: add diff file Thanks
Add Quanta OEM code: ipmitool for DIMM slot readable feature
vendor: Add YADRO VESNIN identification
pcap or verbose log replay tool
This patch only speeds up the echo command output. It doesn't speed up anything else. I don't see how this may help in situations when sp (service processor?) is "not communicable". Besides, next time please attach patches rather than copy-paste them. Or better yet, create pull requests.
I just got this. Re: [ipmitool:bugs] #491 New Private Enterprise Number (PEM) from iana. On 3/29/2018 4:43 PM, Alexander Amelkin wrote: labels: --> IANA status: open --> closed-fixed assigned_to: Alexander Amelkin Group: version-1.8.18 --> version-1.8.19 [bugs:#491] https://sourceforge.net/p/ipmitool/bugs/491/ New Private Enterprise Number (PEM) from iana. Status: closed-fixed Group: version-1.8.19 Labels: IANA Created: Wed Aug 02, 2017 10:14 PM UTC by Dan Gilson Last Updated: Thu Mar 29, 2018 11:42...
Thanks kindly!
This has been addressed by [9d4113].
New Private Enterprise Number (PEM) from iana.
Normally, one would attach a patch or submit a pull request. However, this has been now fixed once and for all (I hope) with commit [9d4113]. The list of PENs is fetched directly from IANA at build time. So the next release (whenever it happens) will include your PEN. You may build ipmitool from sources to get this support right away.
Included Cisco IANA in
ID:491 - Fetch vendor IDs from IANA
This has been addressed by [9d4113].
This has been addressed by [9d411].
timestamp invalid
This has been fixed with commit [9689fe] back in 2008 by Carol Hebert. Closing.
Node Manager Get Policy Command doesn't return Next valid Policy ID and Number of Policies if Policy ID is invalid
Can't get data of Node Manager Policy ID 255
Run Node Manager some commands will cause Segmentation fault.
Patching ipmitool to response more quickly if sp is not communicable.
Tcgetattr show error promp if stdin is not a tty.
Included Cisco IANA in
Found the root caue for issue, When using the open ipmi interface for in band commands in sdr list command, for some of the SDR which has different target address other BMC will try to do the bridging command over BMC, but since we are not validating the SENSOR Owner ID bit in target address it will try to send the command for IPMB channel which is not at all exits. Added the check to verify the SENSOR OWNER ID before framing the bridge command. Attaching the patch
Ipmitool sends incorrect format of Platform Event when it's using SSIF (SMBUS System Interface)
Can't get sensor reading using sdr command via a bridge
Can't clear SEL from local interface if using a BMC as a bridge and sending command to another BMC
Response to system GUID command is not as per the IPMI specification
Getting error "Unable to send command: Invalid argument" in open ipmi interface.
Can anyone please lookup this issue? Its in open state from quite a long time.
Ping.
Fix for ID:497 - long response crashes raw command
Can't get the bios in UEFI mode
Modify the MRC to distinguish Purley and Grantley.
Here is a patch that fixes the problem by allowing larger cmd and response buffers for raw.
long response crashes raw command
Add Supermicro memory MRC and memory RAS
Hello, We encountered the same issue here. I noticed that when I revert the changes for issue #456 I can properly set the vlan to disabled again. Looks like that fix causes some regression. What can I do to get this resolved? Cheers
SOL session is getting disconnected with Segmentation fault message