Menu

Strict Standards: Declaration of ipbwiki30

Help
2012-01-01
2013-05-28
1 2 > >> (Page 1 of 2)
  • Extreame™

    Extreame™ - 2012-01-01

    Hey guys

    I have IPBwiki 2.2.4 and MW 1.18 installed to IP.Board 3.2.3

    No problems installing on both sides, but when I try to access the wiki (wiki/index.php), this is the error I get:

    Strict Standards: Declaration of ipbwiki30::generate_password_salt() should be compatible with that of ipbwiki20::generate_password_salt() in /home/board/public_html/forum/ipbwiki30.php on line 23
    Warning: Cannot modify header information - headers already sent by (output started at /home/board/public_html/forum/ipbwiki30.php:23) in /home/board/public_html/forum/wiki/includes/WebResponse.php on line 38
    

    Any help is appreciated.

     
  • Extreame™

    Extreame™ - 2012-01-01

    I should mention that the "Warning: Cannot modify header information" is repeated 8 times

     
  • Peter Newman

    Peter Newman - 2012-01-01

    You must have some very strict warning settings on your PHP install to be getting that error.

    Anyway if you change line 310 of forum/ipbwiki20.php to read this, so adding =5:

        function generate_password_salt($len=5) {
    

    Then the error should go away.

     
  • Extreame™

    Extreame™ - 2012-01-01

    Thanks, yes we have a strict php policy on the server.

    After the change to line 310, the above error went away, however, now I have this:

    Fatal error: Call to undefined method Skin::makeGlobalVariablesScript() in /home/board/public_html/forum/wiki/skins/ipbwiki_skin.php on line 120
    

    I do appreciate your time with this.

     
  • Peter Newman

    Peter Newman - 2012-01-01

    Out of interest, do you know what the error_reporting setting is for PHP on your server. It would make sense for me to try and test against it in future.

    The new error is a feature change in MW1.18. The quick fix for the moment is to use something other than the IPBWiki skins. The next best option is to workaround it using https://bugzilla.wikimedia.org/show_bug.cgi?id=32702 and this patch https://www.mediawiki.org/wiki/Special:Code/MediaWiki/107595.

    I will hopefully have a better fix in place soon.

     
  • Extreame™

    Extreame™ - 2012-01-02

    The error_reporting settings are as follows:

    Master value = 6135
    Local value = 6983

    After patching the 2 files in the above workaround (we want to have IPBWiki skins), we now get this error:

    Fatal error: func_get_args(): Can't be used as a function parameter in /home/board/public_html/forum/wiki/includes/RequestContext.php on line 397
    

    Is there a better way to get this to work with/without any major changes to server?

    We have php v5.2.17, any changes will need to be passed by our server admins for security considerations.

    Again, I do appreciate the time you are spending on this.

     
  • Peter Newman

    Peter Newman - 2012-01-02

    Thanks for the error_reporting settings, I'll try and remember to give those a go in future.

    I manually applied those patches, and mine is working fine now, although I've been messing around with my skin files a bit, but I don't think I would have fixed or avoided anything. I've never seen that error before, and Google has no hits. I'd be slightly curious if your includes/RequestContext.php matches the MW Subversion copy here http://svn.wikimedia.org/viewvc/mediawiki/tags/REL1_18_0/phase3/includes/RequestContext.php?view=markup, as mine certainly doesn't.

    Can you/have you tested if the wiki still works with the default Vector skin?

    I assume you're using ipbwiki_skin rather than ipbwiki_skin_monobook?

     
  • Extreame™

    Extreame™ - 2012-01-02

    My includes/RequestContext.php does match the MW Subversion copy that you supplied.

    I am using ipbwiki_skin.

    I have tested the wiki with the default Vector skin and I get database errors (Not sure if this is correct as the time does not match, will include anyway):

    ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
     Date: Mon, 02 Jan 2012 02:51:24 +0000
     Error: 1146 - Table 'board_ipb.skin_sets' doesn't exist
     IP Address: <SNIP> - /forum/admin/index.php?adsess=15cf48d70c6ed902a05a1d4706b15ee9&app=ipbwiki&&module=ipbwiki&section=ipbwiki&do=saveskin
     ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
     mySQL query error: SELECT set_cache_css, set_image_dir FROM skin_sets s WHERE set_skin_set_id=2
     .--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------.
     | File                                                                       | Function                                                                      | Line No.          |
     |----------------------------------------------------------------------------+-------------------------------------------------------------------------------+-------------------|
     | admin/applications_addon/other/ipbwiki/modules_admin/ipbwiki/ipbwiki.php   | [admin_ipbwiki_ipbwiki_ipbwiki].saveskin                                      | 114               |
     '----------------------------------------------------------------------------+-------------------------------------------------------------------------------+-------------------'
     | admin/sources/base/ipsController.php                                       | [admin_ipbwiki_ipbwiki_ipbwiki].doExecute                                     | 302               |
     '----------------------------------------------------------------------------+-------------------------------------------------------------------------------+-------------------'
     ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
     Date: Mon, 02 Jan 2012 03:01:51 +0000
     Error: 1146 - Table 'board_ipb.skin_sets' doesn't exist
     IP Address: <SNIP> - /forum/admin/index.php?adsess=15cf48d70c6ed902a05a1d4706b15ee9&app=ipbwiki&&module=ipbwiki&section=ipbwiki&do=saveskin
     ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
     mySQL query error: SELECT set_cache_css, set_image_dir FROM skin_sets s WHERE set_skin_set_id=2
     .--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------.
     | File                                                                       | Function                                                                      | Line No.          |
     |----------------------------------------------------------------------------+-------------------------------------------------------------------------------+-------------------|
     | admin/applications_addon/other/ipbwiki/modules_admin/ipbwiki/ipbwiki.php   | [admin_ipbwiki_ipbwiki_ipbwiki].saveskin                                      | 114               |
     '----------------------------------------------------------------------------+-------------------------------------------------------------------------------+-------------------'
     | admin/sources/base/ipsController.php                                       | [admin_ipbwiki_ipbwiki_ipbwiki].doExecute                                     | 302               |
     '----------------------------------------------------------------------------+-------------------------------------------------------------------------------+-------------------'
    

    I might try the legacy MW 1.17.1 and see if that helps with the install on a separate test board.

     
  • Extreame™

    Extreame™ - 2012-01-02

    With legacy 1.17.1 it works after adding the additional "=5" to line 310 of forum/ipbwiki20.php

    I will now try the alpha on another test wiki board as the legacy wiki is rather slow.

     
  • Extreame™

    Extreame™ - 2012-01-02

    Alpha 1.19 (phase3-nightly-r107792) works with IPBWiki 2.2.4 after the "len=5" change to line 310 in forum/ipbwiki20.php

    However, the original MW1.18.1 still does not work.

     
  • Peter Newman

    Peter Newman - 2012-01-03

    Sorry, I take it back, mine does match too, I was just getting mixed up with different bits of the file.

    As a total stab in the dark and I don't get the error so this is a complete guess, what happens if you change lines 396-398 of includes/RequestContext.php to the following:

        public function msg( /* $args */ ) {
            $args = func_get_args();
            return call_user_func_array( array( $this->getContext(), 'msg' ), $args );
        }
    

    However my gut feeling is there is something else wrong with your MW1.18 install, given versions before and afterwards work fine, especially given the 1.19 alpha works. Or perhaps your error settings are causing more issues. I assume you meant MW1.18.0, as I'm not aware of a 1.18.1 release.

    What happens if you change to a different skin using wiki/index.php/Special:Preferences, or the preview links on that page, rather than trying to change using the IPB admin area? Did the Vector skin work? I think those DB errors will just appear when you first change skins, and is something that still needs fixing for some CSS changes with IPB3.

     
  • Extreame™

    Extreame™ - 2012-01-03

    Yes you are correct, apologies for the mistake in version numbers, I think when I was writing them out I was thinking of 1.17.1 when I should have written 1.18.0.

    It is 1.18.0 I have installed.

    After changing lines 396-398 of includes/RequestContext.php to the above, I get this error:

    Fatal error: Declaration of SkinTemplate_Orig::outputPage() must be compatible with that of Skin::outputPage() in /home/board/public_html/forum/wiki/includes/SkinTemplate.php on line 1325
    

    I will reinstall (and re-download) IPB 3.2.3 and MW 1.18.0 and see if there is any change, hoping there was a corrupt file.

    However my main goal now is to make the wiki look like my forums, see below for the differences):

    This image is how the wiki looks out of the box:

    This is how it should look:

    Any pointers to get it to this point?

     
  • Extreame™

    Extreame™ - 2012-01-03

    Sorry, I forgot to add that if I change the skin via the admincp I get a DB error.

    I think there maybe something wrong with the install, so I will re-download everything again and do a fresh install.

    I shall update on how that goes in the next day or so.

    As my above response was that I am now looking into getting the skins to look right (with the alpha version), this will be my main priority.

     
  • Peter Newman

    Peter Newman - 2012-01-03

    Yes that last error makes no sense to me, Skin::outputPage() is

    abstract function outputPage( OutputPage $out );
    

    , whereas SkinTemplate_Orig::outputPage() is

    function outputPage( OutputPage $out ) {
    

    , i.e. it just implements an abstract function, which shouldn't be a problem, or else the code can't work.

    You've still not answered what happens if you change to a different skin using wiki/index.php/Special:Preferences, or the preview links on that page on MW1.18.0?

    So your skin issues are with MW1.19.alpha and IPB3.2.3? Unfortunately I don't have IPB3.2.3 yet, so may well struggle to reproduce them. I think there were some comments about the "The Wiki" text in the top in a previous post by someone, but I can't find it. I'd still be concerned by your DB error in the screenshot by the way, I don't think that should be happening. If you view source, what's the context of the "The Wiki" bit of text, what else is around it?

    You could try this, https://sourceforge.net/projects/ipbwiki/forums/forum/1278578/topic/4826986, it sounds like it might match your issue.

     
  • Extreame™

    Extreame™ - 2012-01-03

    Ok, back to 1.18.0

    Fresh install, same issue's up to post 11, changed lines 396-398 of includes/RequestContext.php to the following:

        public function msg( /* $args */ ) {
            $args = func_get_args();
            return call_user_func_array( array( $this->getContext(), 'msg' ), $args );
        }
    

    Now I get a different error:

    Fatal error: Call to undefined method Message::setContext() in /home/board/public_html/wiki/includes/OutputPage.php on line 773
    

    So something has changed with this install, and the error refers to this code:

    $this->mHTMLtitle = $name->setContext( $this->getContext() )->text();
    

    I have tried to change the skin via wiki/index.php/Special:Preferences and I get the same error:

    Fatal error: Call to undefined method Message::setContext() in /home/board/public_html/wiki/includes/OutputPage.php on line 773
    

    Any further thoughts?

     
  • Extreame™

    Extreame™ - 2012-01-03

    Yes the skin issue's are with all installs (that have worked) 1.17.1 and MW 1.19 alpha.

    I cant get 1.18.0 to work as of yet.

    I tried the above changes to /wiki/skins/ipbwiki_skin.php and I get this in both 1.18.0 and alpha:

    Parse error: syntax error, unexpected ';'. expecting T_FUNCTION in /home/board/public_html/wiki/skins/ipbwiki_skin.php on line 980
    

    Remembering that this is in all (working) install's - 1.17.1 and 1.19 alpha - same error

     
  • Peter Newman

    Peter Newman - 2012-01-04

    If I've managed to grab the code in the same way as you, line 980 is here yes?

    <?php echo $wgAuth->ipbwiki->ipbwiki->ipbwiki_lang['total_rates'] ?>: <span id='topic-rating-hits'><?php global $count_rating; echo $count_rating; ?></span>
    

    What happens if you ditch the semicolon after "echo $count_rating" so it becomes the following:

    <?php echo $wgAuth->ipbwiki->ipbwiki->ipbwiki_lang['total_rates'] ?>: <span id='topic-rating-hits'><?php global $count_rating; echo $count_rating ?></span>
    

    Or indeed just delete that whole chunk I quoted above to try it out; I'm assuming you're not using the ratings.

    To clarify, skins other than the ipbwiki_skin work fine on MW1.17.1 and 1.19.alpha? The ipbwiki_skin works, but doesn't look "right" for your board and looks like your screenshots? MW1.18 is just plain broken for you, and no skins work properly, even the built in Vector one?

    When you say fresh install of 1.18, did you remove/rename the existing folder, did you use a new database, was it using the original tar.gz from the MW website, or did you download it again? The fact you're now getting a different error suggests something is somewhat suspect with your server/install, I'd hope you should at least get the same results each time its installed.

     
  • Extreame™

    Extreame™ - 2012-01-04

    Fresh install means fresh download, clean server (no files in directory), clean database (new).

    Basically -  fresh for me is to delete any previous files/databases from the server, re-download new install files, start again.

    I did this 2 times and got the same error (in includes/OutputPage.php on line 773) which suggests that the original MW 1.18.0 download was corrupt.

    All skins work just fine (but the ipbwiki_skin does not "look" right) on 1.17.1 (very slow) and 1.19 Alpha

    I still cant get 1.18.0 working at all, I am stuck on post number 15 with this error:

    Fatal error: Call to undefined method Message::setContext() in /home/board/public_html/wiki/includes/OutputPage.php on line 773
    

    For the code on line 980 of wiki/skins/ipbwiki_skin.php it is the end of the file, so I am stumped at that, the original ipbwiki_skin.php file does not even go to line 980 - so for this I have no clue what it references.

    As for wiki/skins/ipbwiki_skin.php line 980 is the last line, so I am still unsure what that means.

    I just downloaded and installed the latest Alpha and it all works as expected.

    The only code change was on line 310 of forum/ipbwiki20.php

    As for the "The Wiki" text at the top of the page, it has gone, but for this install, I just have the 2 semicolons ; ;

    shown here in the screenshot:

    The rest looks very sweet.

    I will stick with this alpha install as it works very well out of the box with the help of this: https://sourceforge.net/projects/ipbwiki/forums/forum/1278578/topic/4826986 for my live install.

    I am happy to work through the 1.18.0 issue's if you would like to.

     
  • Extreame™

    Extreame™ - 2012-01-04

    Is there any way that we can add the editor that is in the MW skins to the ipbwiki skin?

    Works fine in the MW skin, but wont in the ipbwiki skin.

    I would like these types of features (extensions) in ipbwiki

     
  • Ruedy

    Ruedy - 2012-02-14

    Do you have any solution for the issue with the two semicolon?

     
  • Extreame™

    Extreame™ - 2012-04-03

    To remove the semicolons from the wiki, follow this:

    Open /wiki/skins/ipbwiki_skin.php

    Find:

    <!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">;
        <html xml:lang="en" lang="en" xmlns="http://www.w3.org/1999/xhtml">;
    

    Simply remove the semicolons from the end of these 2 lines, like so:

    <!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">
        <html xml:lang="en" lang="en" xmlns="http://www.w3.org/1999/xhtml">
    

    Save the file, upload back to server - all done.

     
  • Extreame™

    Extreame™ - 2012-04-03

    Why can't I edit these posts?

    Stupid editor is adding extra bits to the above code.

    Just remove the semicolons on the end of line 92 and 93 of "ipbwiki_skin.php"

     
  • Ruedy

    Ruedy - 2012-04-03

    Well, thanks!

     
  • Peter Newman

    Peter Newman - 2012-04-03

    I'm glad you solved your semicolons issue, but I'm rather confused, I went to edit the source code to remove them for the next release, but they aren't there. Checking the history they haven't ever been.

    http://ipbwiki.svn.sourceforge.net/viewvc/ipbwiki/wiki/skins/ipbwiki_skin.php?view=markup

    I can't see how they'd slip into the ZIP file either, and as expected they aren't present there. Did you edit the file at some point, perhaps to fix another issue, possibly copied from the forum, which perhaps inserted some extra/random semicolons. But I'm clutching at straws here.

     
1 2 > >> (Page 1 of 2)

Log in to post a comment.