#58 needs cast on check Mac OSX 10.9.5

[Harrison Bowden]

I casted the enums to int like you suggested earlier on bp/cgr/libcgr.c:1817 and bp/cgr/libcgr.c:1856 and continued the compilation. Now make fails on nm/shared/adm/adm.c:970:10

error: comparison of unsigned expression < 0 is always
false [-Werror,-Wtautological-compare]
if((len < 0) || (len > buffer_len) || (len != data_len))
~~~ ^ ~

I think len has to be casted to int here to.

[Scott Burleigh]

Thanks, Harrison, this is very helpful. Would you please go ahead and do that cast, rebuild, and then see if there are any other bits of code in ION that also fail in the same way? These are things that our other compilers aren't catching, and I would like to fix them all at once rather than open individual bug tickets for each one.

[Harrison Bowden]

the only other one is

nm/shared/utils/utils.c:692:23: error: comparison of unsigned expression <
0 is
always false [-Werror,-Wtautological-compare]
if((size-result_len) < 0)

and then it builds. Are the regression test runtests or runtestset or both?

On Tue, Sep 23, 2014 at 12:57 PM, Scott Burleigh sburleig@users.sf.net
wrote:

Thanks, Harrison, this is very helpful. Would you please go ahead and do
that cast, rebuild, and then see if there are any other bits of code in ION
that also fail in the same way? These are things that our other compilers
aren't catching, and I would like to fix them all at once rather than open
individual bug tickets for each one.

---

• [bugs:#58] http://sourceforge.net/p/ion-dtn/bugs/58 needs cast on
  check Mac OSX 10.9.5*

Status: open
Group: 3.2.1
Created: Tue Sep 23, 2014 05:35 PM UTC by Harrison Bowden
Last Updated: Tue Sep 23, 2014 05:35 PM UTC
Owner: nobody

I casted the enums to int like you suggested earlier on
bp/cgr/libcgr.c:1817 and bp/cgr/libcgr.c:1856 and continued the
compilation. Now make fails on nm/shared/adm/adm.c:970:10

error: comparison of unsigned expression < 0 is always
false [-Werror,-Wtautological-compare]
if((len < 0) || (len > buffer_len) || (len != data_len))
~~~ ^ ~

I think len has to be casted to int here to.

Sent from sourceforge.net because you indicated interest in
https://sourceforge.net/p/ion-dtn/bugs/58/

To unsubscribe from further messages, please visit
https://sourceforge.net/auth/subscriptions/

[Scott Burleigh]

Okay, perfect, I'll make those two changes.

I always use runtests because I never run the entire test suite in a single shot - I run individual tests to check out specific behaviors. runtestset is for running sets of tests, enumerated in named files.

[Scott Burleigh]

Okay, this fix is now posted on the misc-v3.2.2 branch and ready for release.