From: Daniel R. G. <os...@te...> - 2012-07-25 20:21:50
Attachments:
iodbc-build-updates.patch
|
The attached patch addresses a handful of minor issues in iODBC's use of the GNU Autotools, mostly obsolete syntax and nits that the Autotools themselves warn about. (These were spurred largely by the changes to bootstrap.sh.) A walk-through of the changes: ++ acinclude.m4 * Properly quote macro name in AC_DEFUN * Use AC_LINK_IFELSE instead of the obsolete AC_TRY_LINK ++ admin/gtk-2.0.m4, admin/gtk.m4 * Properly quote macro name in AC_DEFUN (These macros could use more work, but as they are third-party, and the third party has not bothered to fix them, I've left out doing more here) ++ bootstrap.sh * Call the various Autotools initialization programs with --warnings=all where applicable, to help with QA (and autoconf also gets no-obsolete so we don't hear about the obsolete usages still in the GTK m4 macros) ++ configure.in * Use AC_CONFIG_HEADERS instead of the obsolete AM_CONFIG_HEADER * Use AS_HELP_STRING instead of the obsolete AC_HELP_STRING * Don't use A[CS]_HELP_STRING inside an echo "...", as this is not how the macro is intended to be used, and it doesn't do much good anyway * Use AM_PROG_CC_C_O because AC_PROG_CC_C_O is not sufficient * Replaced the obsolete AC_LIBTOOL_DLOPEN and AM_PROG_LIBTOOL macros with a call to LT_INIT * Fixed the doc string for --disable-gui * Use AC_RUN_IFELSE instead of the obsolete AC_TRY_RUN * Can't use a variable in the doc string for --with-iodbc-filedsnpath, so replaced "$inidir" with "INIDIR" * Rewrote the config info summary at the end to use "cat <<EOF" instead of a bunch of echo commands; this is more readable and makes getting the tabs right a *lot* easier ++ drvproxy/Makefile.am, drvproxy/gtk/Makefile.am, iodbc/Makefile.am, iodbc/trace/Makefile.am, iodbcadm/Makefile.am, iodbcadm/gtk/Makefile.am, iodbcinst/Makefile.am, samples/Makefile.am * Use AM_CPPFLAGS instead of the obsolete variable name INCLUDES --Daniel -- Daniel Richard G. || da...@te... || Software Developer Teragram Linguistic Technologies (a division of SAS) http://www.teragram.com/ |