[Inode-developer] comment on concept

[M.J.M. E. <mar...@pl...>]

Hello everybody

As I promised we wood give some comment on the Inode concept.=20

=46irst of all, the concept was delivered on time. Great!

Second, For a concept the documentation is not good enough (see comment from
Hans, Bert en Raymond) Thereby the code is not functioning well (and not=20
complete).=20

Perhaps this quality was your intention. I don't know? It won't effect the
end grade. But I do know that without delivering good concepts most projects
fail in the end stage. So I would suggest several things:
*=A0=A0=A0=A0=A0=A0=A0Ramp up the energy your spending in this project;
*=A0=A0=A0=A0=A0=A0=A0Focus much more on team working (so alignment between=
 software and
documentation is getting better).
*=A0=A0=A0=A0=A0=A0=A0Ask more to Me, Raymond, Bert and Hans else the expec=
tations of the
results will not be aligned and you have to spend too much energy in the
project.
*=A0=A0=A0=A0=A0=A0=A0When teammates don't cooperate please let me know. It=
 is not our
meaning to let several people do all the work and so that everybody is
getting good grades. For instance we can change the scope or give you
already made software.
=A0=A0=A0=A0=A0=A0=A0
Question to all of you:
*=A0=A0=A0=A0=A0=A0=A0Is the planning still OK?
*=A0=A0=A0=A0=A0=A0=A0When do you deliver?

Best Regards,


Marco Extra

=2D----------------------------------------------------------------------
Hello,

I was asked to review your prototype. I was under the impression
that this was a functional prototype.

I checked out some files today (Tuesday around 11:45AM), but i wasn't
able to find much documentation!

I'm not familiar with the depths of your system, so documentation is
vital to me.

I only found a meeting report in CVS, and an unfinished Adminguide.

On the wiki, i found an unfinished userguide with only an introduction.
The Adminguide was the same as the CVS version apperently.=20

It seems that the developer guide is also not finished. I reviewed a
concept of this some time ago. I couldn't find a finished document
apart than only the anticipated setup of the document.=20

I tried to install your project on my own system, just to test.

I had some trouble finding the mysql create statements. I found them
eventually on the WIKI. I also needed to do some configuration in
data.php; though i found that file very quickly, but for a working
prototype i'd expect to find such things explained in the adminguide.

Btw, it is much more convenient to upload the mysql create statements
as a single textfile instead of ``wiki text content'': copy/pasting
the statements from the WIKI view will result in errors. You have to
click 'edit' and copy/paste the statements from the HTML FORM editor
in order to use them. It is also usefull to upload this textfile to
CVS, also.=20

I wasn't able to get the prototype to function properly. The
configuration screen generates errors:=20

=A0 =A0Warning: mysql_result(): Unable to jump to row 0 on MySQL result
=A0 =A0index 5 in /home/inode/private_html/itil/ConfigItemScreen.php on
=A0 =A0line 10=20

I wasn't able to do something usefull anyway. I coudn't add, delete
or edit things. If this is a working prototype, and if you have
any time left for delivering, i would suggest serious consideration
of your work.

I also looked briefly at the code. I noticed that the project uses
different coding standards. The file RelationScreen.php contains,
for example, different identation than attributes.php. I find
the attributes.php horrible to read. Here is a snippet:

// -------------------------------------------------------------------

case "delete":
// to be done...
break;
}
}
else
{
switch($action)
{
case "insert":
$sql=3D mysql_query("SELECT * FROM CIType WHERE TypeID =3D ".$typeid."");
$result =3D mysql_fetch_array($sql);
$ciname =3D $result[TypeName];
$actiontitle =3D "Insert Attribute_definition: ".$ciname."";
break;

case "update":
$sql=3D mysql_query("SELECT * FROM Attribute_definition WHERE DefID =3D
".$defid."");
$result =3D mysql_fetch_array($sql);
$actiontitle =3D "Update Attribute_definition: ".$result[DefName]."";
break;

case "delete":
// to be done...
break;
}

// --------------------------------------------------------------------

Everything is stuck at the first column of your editor.

It's nice that the code isn't that complex, but when your project
grows such readability is very, very important. It would be very
nasty if an outsider or even yourself at a much later time has to fix
a bug while the grouping of brackets isn't even simple to resolve by
plain eye.

Raymond.

=2D----------------------------------------------------------------------

Hello,

Hereby my comment on the concept version of Inode.

Admin Guide:
=2D Req: Can I not run on a Windows server (yes, you can! WAMP)
=2D Inst: How do I import the script (add command)
=2D Inst: If I want to run on a separate webserver on Apache, how do I inst=
all
it (127.0.01 implies you run it on localhost)
=2D Inst: Clientside: Do I need Javascript? Do I need Java? Do I need pictu=
res
enabled? Can I use my popup blocker? Do I need cookies?

If you do not know all this, figure it out! You don't even need iNode to do
that!

ConfigItemScreen:
=2D Warning: mysql_result(): Unable to jump to row 0 on MySQL result index 5
in /home/inode/private_html/itil/ConfigItemScreen.php on line 10=20

RelationScreen:
=2D Cannot browse defined relations
=2D Cannot edit defined relations
=2D Cannot delete defined relations
=2D Strange behaviour of pickbox (some already assigned relation remains)

DefinitionScreen:
=2D Cannot add CITypes, AttributeDefinitions or TypeRelations
=2D Cannot edit CITypes, AttributeDefinitions or TypeRelations
=2D Cannot delete CITypes, AttributeDefinitions or TypeRelations

This is hardly a prototype at all!

Best Regards,


Hans Bezemer
=2D----------------------------------------------------------------------