Menu

innounp 0.43 in an endless loop

2015-10-27
2015-11-10
  • Daniel Steiner

    Daniel Steiner - 2015-10-27

    When trying to unpack: [https://www.wetransfer.com/downloads/22ddf19f9d830f90fc4ee36953e01f7320151027102401/0ac426ac7e8db9955518fb6e606aa60420151027102401/3dd363]
    Innounp gets stuck in an endless loop.
    Could you check and fix it?

     
  • fec

    fec - 2015-10-27

    This is old installator (1.3.25). Support for this Inno version was added in innounp 0.42.

    (Freezes in 0.42 and 0.43)

    Download: http://rghost.net/7knX5lfZj

     
  • Ariman

    Ariman - 2015-11-02

    It is not a vanilla 1.3.25, it is ISX version (Inno Setup Extensions) which is not supported.
    But still I confirm endless loop problem. It is a bug that needs to be fixed.

     
  • fec

    fec - 2015-11-08

    Ok, so if ISX version is not supported...

    changing this line (IsCompatibleVersion function):
    if not (s[i] in ['1','2','3','4','5']) or (s[i+1]<>'.') then exit;
    to:
    if not (s[i] in ['1','2','3','4','5']) or (s[i+1]<>'.') or (pos('ISX',s)>0) then exit;
    should fix it.

    Or to make it more "safe":
    if not (s[i] in ['1','2','3','4','5']) or (s[i+1]<>'.') or ((s[i]='1') and (pos('ISX',s)>0)) then exit;

     
  • Ariman

    Ariman - 2015-11-10

    Yes, it is a possible solution.

     

Log in to post a comment.