Re: [Inkscape-devel] Tests and making code testable

[<william.crocker@an...>]

>> The test in question tests the Preferences object.
>> It is not possible to replace it with a stub
>> because then the test becomes meaningless.
> 

I use a command line option to tell my app that
it is being tested. This adjusts its behavior in
a number of respects. For one, this causes each test
to use a unique preference set. That way the
tests do not step on my personal preferences and
multiple tests can be run in parallel.

Just my $.02

Bill

Re: [Inkscape-devel] Move "Task" to the View menu

[Alexandre Prokoudine <alexandre.prokoudine@gm...>]

On 3/14/10, Krzysztof Kosiński wrote:

> I think the "Task" combo box should not be in the main toolbar, but in
> the View menu under the name "UI Layout" or "UI Mode", analogically to
> the "Display Mode" submenu. This fixes three problems at once:
> 1. The main toolbar is no longer super-wide when it's vertical.
> 2. The combo box no longer jumps around the UI.
> 3. The unclear word "Task" is replaced with something more explicit.

It would also fix

4. When main toolbar is off, the whole thing is not accessible.

Alexandre

Re: [Inkscape-devel] Move "Task" to the View menu

[Krzysztof Kosiński <tweenk.pl@gm...>]

W dniu 14 marca 2010 17:32 użytkownik Jon Cruz <jon@...> napisał:
> There will be a task picker button that goes in the toolbar. It is not done yet, so will probably go away.
> So in the final result we will have it in *both* places, just with different widgets exposing the functionality.

Fixing (1) requires removing the combo box from the toolbar.

> The menu item will take a bit more coding to fit in, and will need to go into XML files, etc. That is why it was not done first. We needed to get the behavior exposed to allow those who wanted to test it and give feedback to have an easy way to do so. They were able to do so, and it has been quite helpful. So this will probably go out very soon.

You can look at the existing view mode radio buttons to get a start.
You need to:

1. Add a new ZoomVerb for each UI layout in verbs.cpp:2566 and verbs.h
2. Modify ZoomVerb::perform in verbs.cpp:1556 to switch the layout
3. Update the function update_view_menu in interface.cpp:692 so that
the state of your radio button menus is kept in sync with the desktop
state
4. Modify menus-skeleton.h and add the new verbs in the appropriate place

Regards, Krzysztof

Re: [Inkscape-devel] Move "Task" to the View menu

[Jon Cruz <jon@jo...>]

On Mar 14, 2010, at 7:47 AM, Krzysztof Kosiński wrote:

> Hello
> 
> I think the "Task" combo box should not be in the main toolbar, but in
> the View menu under the name "UI Layout" or "UI Mode", analogically to
> the "Display Mode" submenu. This fixes three problems at once:

There will be a task picker button that goes in the toolbar. It is not done yet, so will probably go away.

So in the final result we will have it in *both* places, just with different widgets exposing the functionality.

The menu item will take a bit more coding to fit in, and will need to go into XML files, etc. That is why it was not done first. We needed to get the behavior exposed to allow those who wanted to test it and give feedback to have an easy way to do so. They were able to do so, and it has been quite helpful. So this will probably go out very soon.

Re: [Inkscape-devel] Move "Task" to the View menu

[Uwe Schöler <mail@uw...>]

Hi Krzysztof,

+1

I think that makes more sense ;)

Sincerely,
UweSch

Am 14.03.2010 15:47, schrieb Krzysztof Kosiński:
> Hello
>
> I think the "Task" combo box should not be in the main toolbar, but in
> the View menu under the name "UI Layout" or "UI Mode", analogically to
> the "Display Mode" submenu. This fixes three problems at once:
> 1. The main toolbar is no longer super-wide when it's vertical.
> 2. The combo box no longer jumps around the UI.
> 3. The unclear word "Task" is replaced with something more explicit.
>
> Regards, Krzysztof
>
> ------------------------------------------------------------------------------
> Download Intel® Parallel Studio Eval
> Try the new software tools for yourself. Speed compiling, find bugs
> proactively, and fine-tune applications for parallel performance.
> See why Intel Parallel Studio got high marks during beta.
> http://p.sf.net/sfu/intel-sw-dev
> _______________________________________________
> Inkscape-devel mailing list
> Inkscape-devel@...
> https://lists.sourceforge.net/lists/listinfo/inkscape-devel
>   

[Inkscape-devel] Move "Task" to the View menu

[Krzysztof Kosiński <tweenk.pl@gm...>]

Hello

I think the "Task" combo box should not be in the main toolbar, but in
the View menu under the name "UI Layout" or "UI Mode", analogically to
the "Display Mode" submenu. This fixes three problems at once:
1. The main toolbar is no longer super-wide when it's vertical.
2. The combo box no longer jumps around the UI.
3. The unclear word "Task" is replaced with something more explicit.

Regards, Krzysztof