[ infobot-Bugs-504455 ] found an awkward line in Irc.pl

[SourceForge.net <no...@so...>]

Bugs item #504455, was opened at 2002-01-16 10:59
Message generated for change (Settings changed) made by djmcgrath
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=102241&aid=504455&group_id=2241

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
>Status: Closed
Resolution: None
Priority: 5
Private: No
Submitted By: Andreas Forster (forsti)
Assigned to: Nobody/Anonymous (nobody)
Summary: found an awkward line in Irc.pl

Initial Comment:
Line 405 of Irc.pl ( "if ($rout & SOCK) {" ) is a bad way to check whether $rout has something to read or not. In my tests, this expression always returns true.

In the current version of the bot, this doesn't cause any problems because this line will only be executed if there _is_ something to read.
But there was a problem when i gave a timeout to the select-statement one line above. Since line 405 is always true, the sysread command in line 406 will be executed and wait until there is something to read from SOCK (which is the job of select).

So the mentioned Bug is harmless, but could make problems when implementing new features.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=102241&aid=504455&group_id=2241