Re: [privoxy-devel] Release date for Privoxy 3.0.19 stable

[Lee <le...@gm...>]

On 12/28/11, Fabian Keil <fk...@fa...> wrote:
> Lee <le...@gm...> wrote:
>
>> On 12/27/11, Fabian Keil <fk...@fa...> wrote:
>> > Lee <le...@gm...> wrote:
>
>> >> I finally got around to checking email again..  Windows build is up on
>> >> SF and, after a bit of poking around, privoxy-setup 3.0.19 is the
>> >> default windows download :)
>> >
>> > Great. I assume you built it with IPv6 support?
>>
>> Yes.  I did the build on a Vista machine using winsetup/GNUmakefile so
>> the configure options were
>>   ./configure --enable-mingw32 --disable-pthread
>> --disable-dynamic-pcre --enable-zlib
>
> It's unfortunate that --disable-dynamic-pcre seems to be
> necessary on Windows, but other than that these look like
> reasonable settings for most users.

All that's required is "./configure --enable-mingw32".  For my
personal use I do everything out of current/ so I haven't been
updating the winsetup/ files.  (there was a time when --enable-zlib
was required.   I thought it was you that changed configure to use the
zlib libraries if they were present and not require the --enable-zlib
flag any more?)   The only time I use winsetup/ is when making a new
release.

>> > I ask because I recently got a request for a Privoxy 3.0.18
>> > binary for Windows without IPv6 support, as the ones with
>> > IPv6 support apparently don't work on "older Windows versions".
>> >
>> > Quoting the German error message:
>> > |Die Datei PRIVOXY.EXE ist nicht verknüpft mit dem fehlenden
>> > Export-WS2_32.DLL:freeaddrinfo.
>> > |
>> > |Ein an das System angeschlossenes Gerät funktioniert nicht
>> >
>> > As the mail was send through an anonymous remailer I couldn't
>> > ask for details. I got the mail twice, so I thought that the
>> > second one went to the mailing list, but I just checked and
>> > it was only sent to my SF address ...
>> >
>> > Do you think it would be feasible to provide both flavours?
>>
>> There's a slight problem.  Doing a build on Vista after a
>>   ./configure --enable-mingw32 --disable-ipv6-support
>> dies with
>> gcc -c -pipe -O2 -DWINVER=0x501   -mwindows -mno-cygwin -Wall -Ipcre
>> jbsockets.c -o jbsockets.o
>> jbsockets.c: In function `get_host_information':
>> jbsockets.c:979: error: `NI_MAXSERV' undeclared (first use in this
>> function)
>> jbsockets.c:979: error: (Each undeclared identifier is reported only once
>> jbsockets.c:979: error: for each function it appears in.)
>> make[1]: *** [jbsockets.o] Error 1

For whatever it's worth
  ./configure --enable-mingw32 --disable-ipv6-support
  make
on WinXP also dies

> Interesting. We probably shouldn't use that define when
> --disable-ipv6-support has been used anyway.

Probably not.. dunno if it's worth the effort to redo the code when we
could just do a
#ifndef NI_MAXSERV

> Does moving the "#include <netdb.h>" above the first
> "#ifdef _WIN32" in jbsockets.c work?

I've seen a few warnings about not mixing windows headers and cygwin
headers.  It'd probably be safer to do
> If it doesn't, simply defining NI_MAXSERV should do:
>
> #ifndef NI_MAXSERV
> #define	NI_MAXSERV	32
> #endif
>
> 32 is the value used on FreeBSD and more than big enough
> to contain any port number as string.

32 is also the value in the windows header :)
w32api/ws2tcpip.h:95:#define NI_MAXSERV 32

Lee


>> I'll try to come up with a fix, but I'd rather not release a version
>> of Privoxy without you reviewing the changes.  I've still got an XP
>> machine - I'll see if a build there works.  If no, your anonymous
>> requester is going to have to wait a day or two for an ipv4 only
>> version.
>
> I assume the requester can live with that and will be glad
> to be able to update at all. If not, she or he should.
>
> Fabian
>