From: <ve...@ar...> - 2010-12-24 17:44:59
|
> I agree that it would require some refactoring, which is why > I also think it might be preferable to do it in two (or more) > separate patches. What do you mean by different patches? Patching the code partially would result in a non-compiling code. > I think port_list and and preg should be moved into both > traditional_url_pattern > and a pcre_url_pattern structure that also holds host_regex. > This would probably > also be a good time to improve the structure member names in > the existing code. OK, but why don't you apply the current patch so maybe we can work on it together? venom00 P.S. Happy Christmas! |