[Ieee80211-devel] Re: [PATCH 4/29] ieee80211 Fixes kernel oops on module unload

[Jeff G. <jg...@po...>]

James Ketrenos wrote:
> diff --git a/include/net/ieee80211_crypt.h b/include/net/ieee80211_crypt.h
> --- a/include/net/ieee80211_crypt.h
> +++ b/include/net/ieee80211_crypt.h
> @@ -25,6 +25,24 @@
>  
>  #include <linux/skbuff.h>
>  
> +#ifdef CONFIG_IEEE80211_WPA_MODULE
> +#ifndef CONFIG_IEEE80211_WPA
> +#define CONFIG_IEEE80211_WPA
> +#endif
> +#endif
> +
> +#ifdef CONFIG_IEEE80211_CRYPT_CCMP_MODULE
> +#ifndef CONFIG_IEEE80211_CRYPT_CCMP
> +#define CONFIG_IEEE80211_CRYPT_CCMP
> +#endif
> +#endif
> +
> +#ifdef CONFIG_IEEE80211_CRYPT_TKIP_MODULE
> +#ifndef CONFIG_IEEE80211_CRYPT_TKIP
> +#define CONFIG_IEEE80211_CRYPT_TKIP
> +#endif
> +#endif

NAK:  Kernel code should -never- mess with CONFIG_xxx symbols, except to 
test them.

	Jeff