[Ieee80211-devel] Re: [PATCH 23/29] ieee80211 Added ieee80211_radiotap.h

[Christoph H. <hc...@in...>]

On Tue, Sep 13, 2005 at 06:35:13PM -0500, James Ketrenos wrote:
> + * are met:
> + * 1. Redistributions of source code must retain the above copyright
> + *    notice, this list of conditions and the following disclaimer.
> + * 2. Redistributions in binary form must reproduce the above copyright
> + *    notice, this list of conditions and the following disclaimer in the
> + *    documentation and/or other materials provided with the distribution.
> + * 3. The name of David Young may not be used to endorse or promote
> + *    products derived from this software without specific prior
> + *    written permission.

Is this actually GPL-compatible?

> +#include <linux/version.h>

shouldn;t be beeded,

> +#include <linux/if_ether.h>
> +#include <linux/kernel.h>
> +
> +/* Kluge the radiotap linktype for now if we don't have it */
> +#ifndef ARPHRD_IEEE80211_RADIOTAP
> +#define ARPHRD_IEEE80211_RADIOTAP 803
> +#endif

please get that right.

> +/* The radio capture header precedes the 802.11 header. */
> +struct ieee80211_radiotap_header {
> +	u_int8_t it_version;	/* Version 0. Only increases
> +				 * for drastic changes,
> +				 * introduction of compatible
> +				 * new fields does not count.
> +				 */
> +	u_int8_t it_pad;

please use u8/etc types as in the rest of the kernel, or SuS
uint8_t/etc types if you really want to.