[Ieee80211-devel] Re: [PATCH 23/29] ieee80211 Added ieee80211_radiotap.h

[Michael Wu <fla...@so...>]

On Tuesday 13 September 2005 21:35, James Ketrenos wrote:
> Michael Wu wrote:
> >(resend, sent to oss.sgi.com by mistake)
> >
> >On Tuesday 13 September 2005 19:35, James Ketrenos wrote:
> >>Added ieee80211_radiotap.h to enhance statistic reporting to user space
> >>from wireless drivers.
> >>
> >>Signed-off-by: James Ketrenos <jke...@li...>
> >
> >I'm not sure, but didn't Mike Kershaw create this patch?
>
> Yes.  Building ieee80211_radiotap.h was all his work.  He also put
> together patches to the ipw2200 to use those headers (which are a part
> of that series that will be sent out after I send out a driver
> compatibility series for the ieee80211 patches)
>
Oh, that reminds me.

A bunch of information that is put into the radiotap header is put inside 
struct ieee80211_rx_stats when the driver passes the frame to the ieee80211 
layer. I think it is a better idea to expand ieee80211_rx_stats to include 
all information necessary for filling in a radiotap header, and let the 
ieee80211 tack on the header.

I would prefer either that or giving drivers access to the generic monitor 
mode path so frames can be passed to userspace ASAP.

Also, we probably want an ioctl or some way to switch between raw ieee80211 
frames and radiotap headers.

-Michael Wu