Re: [Ieee80211-devel] [PATCH] Assoc header fix

[Ivo v. D. <iv...@gm...>]

On Thursday 28 July 2005 17:09, Alejandro Bonilla wrote:
> > Hi,
> >
> > This patch will add the ieee80211_hdr_3addr to the
> > ieee80211_assoc_request_frame structure.
> >
> > Patch is against ieee80211 1.0.3.
> >
> > IvD
> >
> >
> > diff -U 3 -H -w -E -d -r -N -- ieee80211-1.0.3/net/ieee80211.h
> > ieee80211-1.0.3-assoc/net/ieee80211.h
> > --- ieee80211-1.0.3/net/ieee80211.h     2005-07-15
> > 01:53:35.000000000 +0200
> > +++ ieee80211-1.0.3-assoc/net/ieee80211.h       2005-07-28
> > 16:58:30.000000000
> > +0200
> > @@ -566,6 +566,7 @@
> >  } __attribute__ ((packed));
> >
> >  struct ieee80211_assoc_request_frame {
> > +       struct ieee80211_hdr_3addr header;
> >         u16 capability;
> >         u16 listen_interval;
> >         u8 current_ap[ETH_ALEN];
>
> Sorry, What is the difference with this patch and the one for ipw2100 to
> compile against 1.0.3?
> http://ipw2100.sourceforge.net/patches/ipw2100-1.1.2-ieee80211-1.0.3.patch
>
> That patch gives:
> -#define IPW_HEADER_802_11_SIZE		 sizeof(struct ieee80211_header_data)
> +#define IPW_HEADER_802_11_SIZE		 sizeof(struct ieee80211_hdr_3addr)
>  #define IPW_MAX_80211_PAYLOAD_SIZE              2304U
>  #define IPW_MAX_802_11_PAYLOAD_LENGTH		2312
>  #define IPW_MAX_ACCEPTABLE_TX_FRAME_LENGTH	1536
>
> So this is doing ieee80211_hdr_3addr for the ipw2100 to compile with 1.0.=
3,
> but isn't ieee80211_hdr_3addr already there?
>
> I'm confused...

The structures
ieee80211_authentication
ieee80211_probe_response
ieee80211_assoc_response_frame

All contain the ieee80211_hdr_3addr header, I would consider it more logica=
l=20
when ieee80211_assoc_request_frame also contains the header.
And with this patch is also removes the requirement for the=20
ipw2100-1.1.2-ieee80211-1.0.3.patch I guess.
The ieee80211-devel stack is not only for ipw2100 or ipw2200 correct, so on=
ly=20
looking to the ipw drivers and how they operate is not completely=20
appropriate. I think the code must be generic and logical so other drivers=
=20
may take advantage of it as well.

IvD