Re: [Ids-devel] IDS bugfixes/enhancements

[timduru <ti...@ti...>]

>     If you want your stuff integrated into the main stream
>     application, 
> you need to supply diffs of what you're doing.  Not everyone knows how
> to edit those files, and not everyone has the guts to even touch stuff
> they don't quite understand.  Diffs are a lot easier to apply for a
> lot of people, and will also make live for us developers a lot easier.

yes, but I thought juste replacing the function would be easier and more useable by JM Ulrich 
instead of having a diff that might fail.
Replacing the entire function by hand  seemed safer to me until I upgrade to 0.82 and make clean patches.. 
But JM found even a better solution  :o)


>     It doesn't matter what version you've "patched" up, current or
>     old, 
> it can always be back (or fore) ported if needed, but you need to get 
> used to submitting diffs instead.

Ok, well that's what I said in my first post, 
that if there was interest in some / all of the modifications 
that I would take the time to isolate most of them and make clean patches. 
But as I didn't really get many replies of interest, I just didn't do it yet. 
I preferred to deal with the ones who emailed me in private directly and give them my entire code 
and help them making the few configuration modifications. :)

As I said in my first post, some of my modifications might not be of everyones interests, 
so I was more waiting for feedback / requests of what could/should be ported into the main stream. 

So what should I do ? make a huge diff on my version after including the 0.82 modifications ? 
Make one diff for all the small changes / bug fixes 
and another one for the pretty url modifications ? (as that last one is the modification that generates the most changes , might be better to have it separate ? )

or try to make one diff for every single change ? 
(might not be the easiest to integrate though, as diff after diff it'd get more and more difficult to merge as the code would change ? )

I'm not sure what you or others would prefer, what would be easier etc...

Also Is there a way to make the diffs so that if applying one diff after the other it doesn't fail 
because the first diff have already modified the same file / code portion ? 


Do you still have the original ids-0.81.tgz btw ? I don't see it in the download area.. 
that way I could make a diff between 0.81 and 0.82 and include that in my version so I'm up to date with 0.82 to make the diffs on my modifications.

thanks