ids-devel — IDS developers use this list

[Ids-devel] More patches (last of the albumIconName)

[Randy M. <ra...@ac...>]

Attacheed are three little patches that make the albumIconName be relative
to the imageCache. This patch is separate for two reasons; one I clipped
that part out of the previous patch to John*.  Two, this patch will
probably break current settings for album icon images.  Album icon images,
to the best of my understanding, are stored in the albums source
directory, but don't risk overwriting a legitimate album picture because
the icon's file name is prefixed with a '.'

I don't use files that start with a '.', so there is a risk that the
icon filename may overwrite a real image.  The solution is to place it in
the imagecache where there won't be a name collision.  (Images in the
image-cache, have suffixes that distinguish them).


(*) I edit patches by hand since my diffs are otherwise kinda big.

Now to download 6a4,
Randy Maas

[Ids-devel] IDS 0.6a4 available

[John M. <mo...@mu...>]

Howdy.

An IDS 0.6a4 distribution is now available.

http://arwen.hn.org/~john/

New in this version:
- Randy Maas' latest patches
- Support for jpegtran (you'll need to enable it in the admin CGI's prefs)
- A command-line script to pre-generate thumbnail images

There are at least two areas on which I'd appreciate some Perl wizards'
advice:
- the revised rotateImage function in the admin CGI: I haven't used the
system function much, so I'm not sure how to do error-checking.
- line 379 in the admin CGI: This doesn't work if I enter an invalid path
for jpegtran.

Thanks,
John

Re: [Ids-devel] jpegtran

[John M. <mo...@mu...>]

That sounds good to me.

There are now a great number of items on the preferences page. I think 
it might be a good idea to start organizing them into groups. So far, 
I'm thinking:
- Site (site name, site header, site footer)
- Album (thumbnail max dimension, thumbnail corner icon, images/row, 
rows/page)
- Image (default image size, scaled image border width, image quality, 
print ordering, use jpegtran)
- Comments (allow comments, comment abuser filtering)

Any ideas?

John


On Thursday, February 15, 2001, at 07:47 PM, Anders Bandholm wrote:

> On Wed, 14 Feb 2001, John Moose wrote:
>
>> Thanks.
>>
>> What is everybody's opinion on this? Is it worth requiring another 
>> package
>> to do lossless rotations of JPEG's? I like the idea, but folks seem to 
>> have
>> a lot of trouble installing IDS as it is. (I'll admit that my 
>> documentation
>> is pretty sparse...)
>
> I agree that this is one of IDS's strong sides: It does *not* have a 
> lot of
> dependencies. (That is actually why I chose IDS in the first place. I 
> also
> looked at PhotoShelf, but it would have taken me a whole day to 
> install... :-)
>
> Using jpegtran could be an option. A configuration variable could 
> specify the
> location of jpegtran. If this variable is defined, jpegtran is called 
> to do the
> job - if undefined, the current code does it instead.
>
> Cheers,
> Anders
> --
> Anders Bandholm, UNI-C, Aarhus
>   Email: And...@un...
>   Phone:  (+45) 8937-6645   Fax: (+45) 8937-6677    ICQ: 20617502
>   PGP: id=0x42691C89; fp=D7DF EF78 0C55 9E9B  C9EA 3D07 6500 A1BB
>

[Ids-devel] A patch for index

[Randy M. <ra...@ac...>]

This patch is pretty simple.

	1.Adds a more descriptive comment to the code
	2. Is a little more careful on trimming off leading .'s
	3. Makes fileExtension a local variable (my)
	4/ changes the local variable name from image to Pic, since image
		mask an earlier declaration.  (ie two variables had the
		same name)
	5.Sets embeddedComments to a default value
	6. Does some more boundary checking on the embeddedComments
	   and previewName variables
	7. Fixes a spot where ".album.jpg" should be $albumIconName;


BTW: I am aware of a one spot in the current source tree that still uses
".album.jpg" instead of $albumIconName.  I'll send the requsite patches
for that soon.

Randy

Re: [Ids-devel] jpegtran

[Anders B. <And...@un...>]

On Wed, 14 Feb 2001, John Moose wrote:

> Thanks.
> 
> What is everybody's opinion on this? Is it worth requiring another package
> to do lossless rotations of JPEG's? I like the idea, but folks seem to have
> a lot of trouble installing IDS as it is. (I'll admit that my documentation
> is pretty sparse...)

I agree that this is one of IDS's strong sides: It does *not* have a lot of
dependencies. (That is actually why I chose IDS in the first place. I also
looked at PhotoShelf, but it would have taken me a whole day to install... :-)

Using jpegtran could be an option. A configuration variable could specify the
location of jpegtran. If this variable is defined, jpegtran is called to do the
job - if undefined, the current code does it instead.

Cheers,
Anders
--
Anders Bandholm, UNI-C, Aarhus
  Email: And...@un...
  Phone:  (+45) 8937-6645   Fax: (+45) 8937-6677    ICQ: 20617502
  PGP: id=0x42691C89; fp=D7DF EF78 0C55 9E9B  C9EA 3D07 6500 A1BB

[Ids-devel] IDS under mod_perl?

[Caleb E. <ca...@bk...>]

	Just for fun I tried setting up IDS to run inside of mod_perl
	in my Apache.  Soem thigns worked, but anything that is
	accessing configuration variables ala "$mail::Variable" fails
	because the index.cgi namespace is no longer "main".

	Anyone done any work or given any thought about making IDS
	mod_perl-able?  I imagine it'd give some measure of
	performance increase over an external CGI.  Unfortunately,
	this isn't my area of expertise.

-- 
cae at bklyn dot org | Caleb Epstein | bklyn . org | Brooklyn Dust Bunny Mfg.

Re: [Ids-devel] jpegtran

[Anthony A. D. T. <aa...@ta...>]

>jpegtran is one of the sample programs that comes with the independent
>JPEG group's very cross platform JPEG library.

Cool.  Imagemagick uses libjpeg, so IDS using jpegtran wouldn't really
be adding another dependency.

Re: [Ids-devel] jpegtran

[Daniel M. <dtm...@ho...>]

"Anthony A. D. Talltree" <aa...@ta...> writes:

> >What is everybody's opinion on this? Is it worth requiring another package
> >to do lossless rotations of JPEG's? 
> 
> Absolutely, presuming that jpegtran is reasonably portable, eg. not full
> of linuxisms.

jpegtran is one of the sample programs that comes with the independent
JPEG group's very cross platform JPEG library.  (along with djpeg and
cjpeg) If I remember correctly, the Makefile will even allow it to be
compiled as a real mode DOS executeable.  (I don't even think perl5
can do that, though I seem to remember a version of perl4 that ran
that way)

Re: [Ids-devel] jpegtran

[Anthony A. D. T. <aa...@ta...>]

>What is everybody's opinion on this? Is it worth requiring another package
>to do lossless rotations of JPEG's? 

Absolutely, presuming that jpegtran is reasonably portable, eg. not full
of linuxisms.

Re: [Ids-devel] jpegtran

[John M. <mo...@mu...>]

Thanks.

What is everybody's opinion on this? Is it worth requiring another package
to do lossless rotations of JPEG's? I like the idea, but folks seem to have
a lot of trouble installing IDS as it is. (I'll admit that my documentation
is pretty sparse...)

While we're on the subject- does anyone know of other image manipulation
packages we should be looking at? I've often wondered if replacing
ImageMagick with a more specialized program would make IDS noticably faster.
Code profiling suggests that IDS spends most of its time in Image::Magick
and the CGI lib. I chose ImageMagick because of its Perl interface- I've
been trying to avoid making system calls.

BTW, the later versions of ImageMagick do preserve EXIF data through
manipulations.

John



on 2/14/01 6:36 PM, Anders Bandholm at And...@un... wrote:
> Hi!
> 
> First: Thanks for a great package. I really needed something of this sort,
> and IDS seems to have the right level of sophistication: It seems to have
> all the right features - and just those!
> 
> And now a suggestion:
> 
> Have you thought about using 'jpegtran' for rotations? jpegtran has the
> benefit of allowing you make a lossless rotate since it manipulates the
> image file directly without doing the decode/rotate/encode process. An
> added benefit is that it has an option called 'copy all', which copies all
> markers into the rotated image - and this actually preserves Exif data!
> 
> On Debian, jpegtran is part of the libjpeg-progs package
> 
> Cheers,
> Anders
> --
> Anders Bandholm, UNI-C, Aarhus
> Email: And...@un...
> Phone:  (+45) 8937-6645   Fax: (+45) 8937-6677    ICQ: 20617502
> PGP: id=0x42691C89; fp=D7DF EF78 0C55 9E9B  C9EA 3D07 6500 A1BB
> 
> 
> _______________________________________________
> IDS-devel mailing list
> IDS...@li...
> http://lists.sourceforge.net/lists/listinfo/ids-devel
> 

Re: [Ids-devel] Cross device link problem in replace_file

[John M. <mo...@mu...>]

Thanks for the contribution. It will appear in the next release if there are
no objections.

Mike Spiceland and I have corresponded quite a bit. I think he wrote
"myphotoalbum" because, at the time, he wasn't allowed to install the Perl
modules required by IDS on his server. Perhaps he used IDS for examples when
he was developing.  I definitely borrowed the Shutterfly integration idea
from him.

John



on 2/14/01 5:31 PM, Caleb Epstein at ca...@bk... wrote:

> 
> First let me say THANK YOU for the best web-based photo album
> I've come across and I've tried just about all of them.  ids
> rocks.  One curious thing I've noticed is that the code look a
> LOT like the "myphotoalbum" on www.mikespice.com.  Does ids
> originate here or were they both branched from another
> project?
> 
> Now on to the code.
> 
> I've set up my ids directory such that "albums" is a symlink
> to a directory on another filesystem.  This caused problems
> when trying to add comments to directories and files which
> turned out to be due to the "rename" call in replace_file()
> trying to cross a device boundary.
> 
> The patch below changes the name of the temporary file to be in
> the same dir as the file which will be created, thus
> eliminating this problem.
> 
> --- ids-0.6/idsShared.pm        Tue Feb 13 18:42:01 2001
> +++ /var/www/photo/idsShared.pm Wed Feb 14 16:08:32 2001
> @@ -157,7 +157,7 @@
> 
> # try new temporary filenames until we get one that didn't already
> # exist;        the check should be unnecessary, but you can't be too careful
> -       do {$name = "./$$-".int rand 999}
> +       do {$name = "$File.$$-".int rand 999}
> until sysopen(FH, $name, O_RDWR|O_CREAT|O_EXCL);
> 
> # install atexit-style handler so that when we exit or die,

[Ids-devel] jpegtran

[Anders B. <And...@un...>]

Hi!

First: Thanks for a great package. I really needed something of this sort,
and IDS seems to have the right level of sophistication: It seems to have
all the right features - and just those!

And now a suggestion:

Have you thought about using 'jpegtran' for rotations? jpegtran has the
benefit of allowing you make a lossless rotate since it manipulates the
image file directly without doing the decode/rotate/encode process. An
added benefit is that it has an option called 'copy all', which copies all
markers into the rotated image - and this actually preserves Exif data!

On Debian, jpegtran is part of the libjpeg-progs package

Cheers,
Anders
--
Anders Bandholm, UNI-C, Aarhus
  Email: And...@un...
  Phone:  (+45) 8937-6645   Fax: (+45) 8937-6677    ICQ: 20617502
  PGP: id=0x42691C89; fp=D7DF EF78 0C55 9E9B  C9EA 3D07 6500 A1BB

[Ids-devel] Cross device link problem in replace_file

[Caleb E. <ca...@bk...>]

	First let me say THANK YOU for the best web-based photo album
	I've come across and I've tried just about all of them.  ids
	rocks.  One curious thing I've noticed is that the code look a
	LOT like the "myphotoalbum" on www.mikespice.com.  Does ids
	originate here or were they both branched from another
	project?

	Now on to the code.

	I've set up my ids directory such that "albums" is a symlink
	to a directory on another filesystem.  This caused problems
	when trying to add comments to directories and files which
	turned out to be due to the "rename" call in replace_file()
	trying to cross a device boundary.

	The patch below changes the name of the temporary file to be in
	the same dir as the file which will be created, thus
	eliminating this problem.

--- ids-0.6/idsShared.pm        Tue Feb 13 18:42:01 2001
+++ /var/www/photo/idsShared.pm Wed Feb 14 16:08:32 2001
@@ -157,7 +157,7 @@
   
        # try new temporary filenames until we get one that didn't already
        # exist;        the check should be unnecessary, but you can't be too careful
-       do {$name = "./$$-".int rand 999}
+       do {$name = "$File.$$-".int rand 999}
        until sysopen(FH, $name, O_RDWR|O_CREAT|O_EXCL);
 
        # install atexit-style handler so that when we exit or die,

-- 
cae at bklyn dot org | Caleb Epstein | bklyn . org | Brooklyn Dust Bunny Mfg.

[Ids-devel] IDS 0.6a3 available

[John M. <mo...@mu...>]

Good evening.

An IDS 0.6a3 distribution is now available.

http://arwen.hn.org/~john/

This pre-release version includes Oren Teich's sort-by-date code and 
quite a few improvements from Randy Maas:

> 	1. create a configuration variable called "albumIconName"; this
> 		defaults to ".album.jpg".  But the configuration variable
> 		is changeable.  This is neccessary to folks like me who
> 		have webservers that consider files that start with a '.'
> 		to be security risks.
> 	2. Fixed a couple of typos in the messages
> 	3. Fixed the date format to be more legible.
> 	4. Checks to see that the guestComments setting is actually
> 		defined before overriding the default value.
> 	5. More checking that image preview directory (cache) exists and
> 		is sensible.
> 	6. Eliminates unneccessary undefs
___________

> 	* a bit more checking to make sure variables are defined or have
> 	  reasonable values (ie, no divide by zero)
> 	* A couple of lines of comments to help explain parameters to a
> 	  subroutine
> 	* removed a redundant declaration
> 	* fixed a typo in an error message
> 	* made rename work for the image cache (or atleast a bit more of
> 		the image cache)
> 	* removed a loop label that was unneccessary.


John

RE: [Ids-devel] sort by date patch

[Oren T. <ore...@su...>]

darn it - there's a bug.  It doesn't display "next image" and "previous"
image sorted by date right.

chanage index.cgi:376

sort='.$sort.'
to
sort=".$sort."

and it should work right.

-------------------------------------------

I vote for EXIF data.  Much better idea.

If you replace the foreach loop that currently sorts in the 3 or 4 locations
around the file with this one:

        foreach my $fileName (@itemsToDisplay) {
                my($camdate,$camtime);
                my($picinfo) = image_info($fileName);
                if ((defined($picinfo->{'DateTimeOriginal'})) &&
($picinfo->{'DateTimeOriginal'} ne '0000:00:00 00:00:00')) {
                        $camdate = $picinfo->{'DateTimeOriginal'};
                        my ($date,$time) = split / /, $camdate;
                        my ($year,$month,$day) = split /:/, $date;
                        my ($hour,$min,$sec) = split /:/, $time;
                        $month--;
                        $year -= 1900;
                        $camtime =
timelocal($sec,$min,$hour,$day,$month,$year);
                        $mtime{$fileName} = $camtime;
                } else {
                        my $modTime = (stat $fileName)[9];
                        $mtime{$fileName} = $modTime;
                }
        }

it'll sort by exif date if it exists, else by mtime.

I think I should have just made this a function that each place can call...

Oren

Re: [Ids-devel] sort by date patch

[Anthony A. D. T. <aa...@ta...>]

>Poll: should the date comparison be done on the file's date or on the date
>embedded in the image's EXIF data (if present)?

The latter.  It's easy when moving the files around to change the file's
date -- if in fact it ever did correspond to the shutter date.  IIRC
gphoto eg. doesn't date uploaded image files.

Re: [Ids-devel] sort by date patch

[John M. <mo...@mi...>]

I added a little interface for Oren's sort-by-date code.

http://arwen.hn.org/~john/ids-0.6/

Poll: should the date comparison be done on the file's date or on the date
embedded in the image's EXIF data (if present)?

John 

________________________________________________________________
John Moose                                    mo...@mu...

On Tue, 6 Feb 2001, Oren Teich wrote:

> Here's a patch that adds sort by date functionality.
> 
> I however, suck at UI work, and couldn't think of a good way to add this to
> the to the UI, but if you just make sure ids gets  a sort=date or sort=name
> passed somehow, it should work fine.
> 
> Sorry for the atachment -- my mailer would wrap it otherwise.
> 
> Oren Teich
> ore...@su...

[Ids-devel] sort by date patch

[Oren T. <ore...@su...>]

Here's a patch that adds sort by date functionality.

I however, suck at UI work, and couldn't think of a good way to add this to
the to the UI, but if you just make sure ids gets  a sort=date or sort=name
passed somehow, it should work fine.

Sorry for the atachment -- my mailer would wrap it otherwise.

Oren Teich
ore...@su...

[Ids-devel] IDS 0.52 testers needed

[John M. <mo...@mu...>]

Hello.

IDS 0.52 is almost ready to be released. It includes some new features, 
like the ability to order prints through Shutterfly.com, and several 
bug-fixes, like correctly setting the permissions of directories.

You can see it in action at:
http://toasty.mcs.muohio.edu/~moosejc/photoalbum/

If you'd like to help me test IDS 0.52, you can download it at:
http://arwen.hn.org/~john/ids-0.52b3.tar.gz

Please let me know what you think.

Thanks,
John

[Ids-devel] "Unable to open file" error

[Jeff W. <je...@js...>]

Kept getting an unable to open file error in the Apache error log when viewing
the full size photos and the pathname to the image file name was duplicated
twice within the error message.  This may already be fixed, but the following
patch against 0.51 fixes it.

Thanks,
Jeff

--- idsShared.pm    Tue Dec  5 19:06:58 2000
+++ idsShared.pm        Sun Jan 28 10:40:16 2001
@@ -372,7 +372,7 @@
        $type = '' unless defined $type;
        my($previewName) = filenameToDisplayName($imgName, $previewMaxDimension);
        createDisplayImage($previewMaxDimension, $ppath, $previewName,
-                          $ppath."albums/$albumName/$imgName");
+                          $ppath."albums/$albumName/$base");
        my($prettyImageTitle) = $base;
        $prettyImageTitle =~ s/\#\d+_//g;
        $prettyImageTitle =~ s/\.(\S+)\Z//;


-- 
Message of the Message:
If I traveled to the end of the rainbow
As Dame Fortune did intend,
Murphy would be there to tell me
The pot's at the other end.
		-- Bert Whitney