Re: [Idesk-devel] zombiebug and featurerequest

[Thierry C. <tco...@wa...>]

Hello everybody,

I noticed also the zombie processes bug in idesk.
Made a quick fix. I change the XDesktopContainer::runCommand method.
Here is the new code :
void XDesktopContainer::runCommand(const string & command)
{
    pid_t pid;
  
    //fork and execute program
	if (pid=fork() != 0) {
		setsid();
		execl("/bin/sh", "/bin/sh", "-c", command.c_str(), 0);
		exit(0); //exit fork
	}
	waitpid(pid, NULL, 0);
}

Works on my gentoo. It is a simple fix but please test.
Btw, if somebody can tell me the prefered way to make a patch file, I'll post that.

For the launch of the programs with sh, idesk already does that.

Hope this helps.

On Sun, 20 Jul 2003 16:13:02 +0200
Tue Abrahamsen <tw...@wt...> wrote:

> Hello,
> 
> I have a bugreport and a feature-request:
> 
> The bug is that idesk 0.5.5 doesn't close the programs is starts 
> properly. A 'ps ax' shows many zombieprocesses on my system after 
> having used idesk for a while.
> 
> The feature-request is that I think, when starting program, they should 
> be invoked through 'sh', as 'sh' will read enviroment variables from 
> ~/.bashrc and alike, which some programs need to run properly.
> 
> 
> // Tue Abrahamsen (twoface at wtf dot dk)
> 
>     "There is no system but GNU, and Linux is one of its kernels."
>                                       - Richard Stallman
> 
> 
> -------------------------------------------------------
> This SF.net email is sponsored by: VM Ware
> With VMware you can run multiple operating systems on a single machine.
> WITHOUT REBOOTING! Mix Linux / Windows / Novell virtual machines at the
> same time. Free trial click here: http://www.vmware.com/wl/offer/345/0
> _______________________________________________
> Idesk-devel mailing list
> Ide...@li...
> https://lists.sourceforge.net/lists/listinfo/idesk-devel