[icqlib-dev] BSD Fix, and question about two callbacks

[Eric W. <war...@ya...>]

Hi,

In order to compile the icqlib that's currently in CVS on FreeBSD 4.2, I
had to add

#include <sys/types.h>

before the sys/socket.h include in icqpacket.c and socketmanager.h.

Also, I had a question about the InvalidUIN and WrongPassword callbacks.
In udphandle.c, the both have invoke_callback followed by

icq_UDPAck(icqlink, seq);

In kicq though, both callbacks lead to the icqlink being deleted
(both callbacks call RegWindow::stop, which calls RegWindow::disconnect,
which calls icq_ICQLINKDelete).

Once the icqlink is deleted, it returns to icq_ServerResponse in udphandle.c,
which immediately tries to use it.

Shouldn't the calls be reversed? The icq_UDPAck first and then
invoke_callback?

Eric