#21 icns2png.c:70: possible missing "," ?

[dcb]

I just tried to compile the package with new C compiler clang-14.

It said:

icns2png.c:70:49: warning: suspicious concatenation of string literals in an array initialization; did you mean to separate the elements with a comma? [-Wstring-concatenation]

Source code is

const char *sizeStrs[] = { "1024", "1024x1024" "512", "512x512", "256", "256x256", "128", "128x128", "48", "48x48", "32", "32x32", "16", "16x16", "16x12" };

Maybe better code:

const char *sizeStrs[] = { "1024", "1024x1024", "512", "512x512", "256", "256x256", "128", "128x128", "48", "48x48", "32", "32x32", "16", "16x16", "16x12" };

[Paul Wise]

Thanks for the report, I have fixed this in the git repository with this commit:

https://sourceforge.net/p/icns/code/ci/921f972c461c505e5ac981aaddbdfdde97e8bb2b/

BTW, if you have any further changes, I suggest you use the SourceForge merge requests feature. First you make a fork of the git repository, then you push to your fork, then you request we merge your fork into the main git repository.

https://sourceforge.net/p/icns/code/fork
https://sourceforge.net/p/icns/code/merge-requests/