#19 regression?: won't unpack the test files that ship with it, etc.

[tyler]

built with latest git source (20170906) on linux with gcc 7.3.0

test1, test2, and test3 are from the samples folder that comes with thte code.

> icns2png -x test1.icns

Reading icns family from test1.icns...
libicns: icns_read_family_from_file: Error reading icns file - all parsing methods failed!
Unable to read icns family from file test1.icns!
Errors while extracting icns data from test1.icns!

Same for test2.rstc and test3.bin (not sure if it was supposted to work for them)

Also, same error message for ICNS of the "TOC" type.

I tested an older ICNS with type ics# as the first icon, and it worked as expected.

Version 0.8.1, built on the same machine, failed in the same way.

[tyler]

I'm getting some success unpacking "TOC"-type ICNSs, but not ones that were extracted from iContainers.

[Paul Wise]

I did a git bisect to figure out what happened.

Looks like I broke them when I removed trailing whitespace in commit 868eb6b.

I've reverted them to the previous state in the latest git commit.

[tyler]

So, what is fixed, the test icns files or the c code? In other words, do I need to recompile?

Edit: never mind, I see what was changed. Thank you!

[tyler]

Final question: Should the output be the same for all three? I see three different versions of the gnu.

[Paul Wise]

Only the test files were broken, so only they were fixed. No need to recompile.

The output you are seeing is correct.

[tyler]

Thanks again. Over and out.