|
From: Mark P. <mpe...@sq...> - 2025-08-05 18:16:24
|
Hi Damjan
On Tue, Aug 5, 2025, at 9:40 AM, Damjan Georgievski wrote:
> Hi all,
> I've been compiling recent torvalds/master and noticed I've lost the
> control of the *mute mic led* (on the Thinkpad X9-14).
>
> For context, the `snd-ctl-led` ("ALSA control interface to LED trigger
> code") allows the mic mute led to follow the muted state of the
> microphone capture mixer,
> and to select if you want the led on when the mic is muted or is capturing.
>
> Problem is, both SND_HDA_GENERIC_LEDS and SND_CTL_LED are not user
> selectable, and
>
> * SND_CTL_LED is selected/enabled by SND_HDA_GENERIC when
> SND_HDA_GENERIC_LEDS is enabled; and
> * SND_HDA_GENERIC_LEDS is only selected by 4 of the codecs in
> `sound/hda/codecs/`.
>
> Now none of those 4 codecs are required on *this* Thinkpad, so not
> sure what the proper solution should be.
>
> I did fix the issue *for me* by adding
> `select SND_HDA_GENERIC_LEDS if SND_HDA_GENERIC` to `config
> THINKPAD_ACPI` - but I'm not sure if that's the proper way forward.
>
I assume you're using your own config instead of a standard one from a distro? I checked with both Ubuntu and Fedora (that I have on my system currently) and they have this option enabled - but they also have Realtek (and others) enabled which would have pulled it in.
I believe the X9-14 uses the Cirrus codec so my guess is we should be adding this to the Cirrus Kconfig. Let me just check with the Cirrus folk if they have any thoughts/concerns.
As a heads up - if you're using the X9-14 keep an eye on this proposed fix:
https://lore.kernel.org/linux-input/202...@ca.../T/#t
It fixes a rare kernel crash condition we've been seeing on suspend/resume
Mark
|
