[ibm-acpi-devel] SND_HDA_GENERIC_LEDS/SND_CTL_LED dependency of config THINKPAD_ACPI

[Damjan G. <gd...@gm...>]

Hi all,
I've been compiling recent torvalds/master and noticed I've lost the
control of the *mute mic led* (on the Thinkpad X9-14).

For context, the `snd-ctl-led` ("ALSA control interface to LED trigger
code") allows the mic mute led to follow the muted state of the
microphone capture mixer,
and to select if you want the led on when the mic is muted or is capturing.

Problem is, both SND_HDA_GENERIC_LEDS and SND_CTL_LED are not user
selectable, and

* SND_CTL_LED is selected/enabled by SND_HDA_GENERIC when
SND_HDA_GENERIC_LEDS is enabled; and
* SND_HDA_GENERIC_LEDS is only selected by 4 of the codecs in
`sound/hda/codecs/`.

Now none of those 4 codecs are required on *this* Thinkpad, so not
sure what the proper solution should be.

I did fix the issue *for me* by adding
`select SND_HDA_GENERIC_LEDS if SND_HDA_GENERIC` to `config
THINKPAD_ACPI` - but I'm not sure if that's the proper way forward.


--
damjan