Hi Ilpo
On Thu, Jun 5, 2025, at 4:03 AM, Ilpo Järvinen wrote:
> On Wed, 4 Jun 2025, Mark Pearson wrote:
>
>> Create lenovo subdirectory for holding Lenovo specific drivers.
>>
>> Signed-off-by: Mark Pearson <mpe...@sq...>
>> ---
>> Changes in v2:
>> - Rebased to Linus's latest as requested
>> - Updated documentation reference
>> - Updated MAINTAINER file
>> - Removed X86_PLATFORM_DRIVERS_LENOVO as I was worried about
>> maintaining backwards compatibility for the distros.
>> - Removed 2nd patch in series splitting out hkeys. That will be for
>> the future
>
> +# Lenovo x86 Platform-Specific Drivers
> +# Lenovo X86 Platform Specific Drivers
>
> Any possibility to be consistent in formatting that? :-)
>
Ooops - yes. I'll fix.
> Why does the admin guide contain a history book?? It should be guide for
> this version of kernel, not what was there in 2.6.x era ;-D. Please don't
> add to that any more, preferrably remove the history part afterwards in a
> separate change.
>
Sure. Will remove that change from the commit.
I was just trying to make sure I updated in all the right places and realised I hadn't checked the documentation files and found that reference.
> Other than those mentioned above, diffing per vs post seemed clean (I
> didn't check where the empty lines got added, Andy seemingly did already
> :-)).
>
Thanks for the review.
Mark
|