|
From: Hans de G. <hde...@re...> - 2024-04-23 14:00:28
|
Hi, On 4/22/24 10:07 AM, Ilpo Järvinen wrote: > On Sun, 21 Apr 2024, Hans de Goede wrote: > >> send_acpi_ev, ignore_acpi_ev are already initialized to true resp. false by > > Wording here is odd (but I'm not native so could be I just don't > understand what "true resp. false" is supposed to mean/fit into the > general structure of this sentence). I could nonetheless guess the > general meaning of the sentence despite that, but you might want to > consider rewording it into something that is easier to understand. Ok, I have changed this to: """ send_acpi_ev and ignore_acpi_ev are already initialized to true and false respectively by hotkey_notify() before calling the various helpers. Drop the needless re-initialization from the helpers. """ now. > > The code change is fine, > > Reviewed-by: Ilpo Järvinen <ilp...@li...> Thank you. Regards, Hans |
