Re: [ibm-acpi-devel] [PATCH v1 1/5] ACPI: utils: Introduce acpi_match_video_device_handle() helper

[Rafael J. W. <ra...@ke...>]

On Fri, Jul 1, 2022 at 7:47 AM Mika Westerberg
<mik...@li...> wrote:
>
> Hi Andy,
>
> On Fri, Jul 01, 2022 at 12:28:15AM +0300, Andy Shevchenko wrote:
> >  extern long acpi_is_video_device(acpi_handle handle);
> > +extern bool acpi_match_video_device_handle(acpi_handle handle);
>
> I think we can do slightly better here. The only caller of
> acpi_is_video_device() is in drivers/acpi/video_detect.c so we can move
> it there and make it static (is_video_device()).
>
> Then we can name this one acpi_is_video_device() instead and in addition
> make it take struct acpi_device as parameter instead of acpi_handle (I
> think we should not use acpi_handles in drivers if possible).

Agreed.