|
From: Mae D. <he...@ma...> - 2022-04-22 20:09:46
|
On 2022-04-22 14:15, Mae Dartmann via ibm-acpi-devel wrote: > Hi, > > I recently got my hands on a ThinkPad L13 Yoga Gen 2 AMD (the 5850U > spec). It works great on Linux, except for the tablet mode switch, > which appears to be broken on mainline (I'm running 5.18-rc3), as well > as older kernels. > > dmesg shows an error that appears to originate from the > `hotkey_gmms_get_tablet_mode` function in > drivers/platform/x86/thinkpad_acpi.c, specifically when checking if > the mode is valid (lines 2020ff.): > > thinkpad_acpi: Unknown/reserved multi mode value 0x0000 for type 4, > please report this to ibm...@li... > > I have opened a bug report in the kernel bugzilla > (https://bugzilla.kernel.org/show_bug.cgi?id=215873), but I thought I > would do as the module tells me and report this issue in the mailing > list, too. > > I don't have much experience in kernel development so I might not be > much help, but please let me know if I can test something, try out > patches, etc. I run my own distribution on the machine, so patching > and compiling kernels is not a big deal for me. > > Thanks > --- > Mae Dartmann > git : https://github.com/mdartmann > mail: he...@ma... > > > _______________________________________________ > ibm-acpi-devel mailing list > ibm...@li... > https://lists.sourceforge.net/lists/listinfo/ibm-acpi-devel Update: I spent the last day or so inserting printk statements at various points throughout the driver, as well as using acpica to see if/when the hotkey logic in the driver runs. As far as I can tell, this devices' tablet switch does not get recognized at all by the driver, turning the screen around does not trigger anything in the driver. There are no calls to acpi_evalf, the hotkey_notify function does not recognize the event, and I can't see any ACPI_EVENTS through /sys/module/acpi/debug_layer. hotkey_gmms_get_tablet_mode only gets run on boot, resume or when reading /sys/bus/platform/devices/thinkpad_acpi/hotkey_tablet_mode. I have Windows 11 installed on the same machine, it works perfectly there. I identified that the driver that handles tablet mode is called "Microsoft HID GPIO Laptop or Slate Indicator Driver". If needed, I can provide the information it exposes via device manager. I am way out of my depth here. I can kind of piece together what is wrong and what the driver is doing, however, I have no clue how ACPI works or how I could fix this. Let me know if I can provide any more information, from the windows driver or otherwise. Thanks --- Mae Dartmann git : https://github.com/mdartmann mail : he...@ma... |