|
From: Mark P. <mar...@le...> - 2020-08-03 16:16:11
|
On 8/3/2020 10:46 AM, Elvis Stansvik wrote: > > Thanks Mark. I know the X1C6 firmware did not get the new thermal > mode implementation, but thought that I would still be able to query > its lap mode. > > The reason I wanted query the lap mode is actually because I'm > trying to help Matthew Garrett out in adding support for the adaptive > DPTF performance policy on the thermald side, instead of on the > firmware side like Lenovo decided to do for more recent models. See > that effort here https://github.com/mjg59/thermal_daemon/issues/7). > We were surprised to find that all of the OEM conditions in the APCT > table remained unchanged when the laptop was taken between lap and > desk. So I started suspecting that perhaps the X1C6 and its firmware > simply does not have the ability to detect lap vs desk. That's why I > wanted to use this patch to query the lap mode, as a debugging aid. > > If X1C6 does not have the ability to detect lap mode, then that > would obviously explain why the firmware does not change any APCT > condition when put on/off lap, and any effort to get adaptive > performance policy working on the thermald side is probably doomed > :( > Just as a follow-up for this mailing list - I responded to the X1C6 issues on the thermal_daemon thread mentioned above - I will track those there. Anything related to the thinkpad_acpi driver and improvements needed to my previous patch will come here. I have a question in to the firmware team to understand the limitations of when the lapmode variable should be made available or not. Looks like I have some work to do there.... Thanks! Mark |
