|
From: Pavel M. <pa...@uc...> - 2019-05-02 19:13:34
|
Hi! > >>>+++ b/drivers/leds/led-class.c > >>>@@ -57,6 +57,7 @@ static ssize_t brightness_store(struct device *dev, > >>> if (state == LED_OFF) > >>> led_trigger_remove(led_cdev); > >>> led_set_brightness(led_cdev, state); > >>>+ flush_work(&led_cdev->set_brightness_work); > >> > >>Is this really required here? It creates non-uniform brightness > >>setting behavior depending on whether it is set from sysfs or > >>by in-kernel call to led_set_brightness(). > > > >This fixes the echo 0 > brightness; echo 1 > brightness. It has to be > >at a place where we can sleep. > > > >If you have better idea, it is welcome, but it would be good to fix > >the bug. > > Currently not, so I applied the patch in this shape. Thanks! This is actually something that makes sense for stable.. perhaps the bots can pick it up. Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html |
