Re: [ibm-acpi-devel] [PATCH v2] platform/x86: thinkpad_acpi: extend battery quirk coverage

[Andy S. <and...@gm...>]

On Thu, Aug 2, 2018 at 11:28 PM, Jouke Witteveen <j.w...@gm...> wrote:
> Based on bug reports and a web search for
>     "Thinkpad_acpi: Error probing battery 2"
> four more models were found that require the battery quirk:
> Lenovo B5400, Thinkpad 11e, Thinkpad 11e gen 3, Thinkpad 13 gen 3.
>

Pushed to my review and testing queue, thanks!

> Signed-off-by: Jouke Witteveen <j.w...@gm...>
> Tested-by: James Cheshire <jer...@gm...>
> Acked-by: Henrique de Moraes Holschuh <hm...@hm...>
> ---
>
> I avoided the ping-pong style and added James Cheshire as a tester.
> Andy suggested to Cc: him, but if I understand the kernel documentation on
> submitting patches correctly, a Tested-by: is in order. James tested on a
> Thinkpad 11e and agreed to be included in the commit message.
>
>  drivers/platform/x86/thinkpad_acpi.c | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c
> index 3dbff2dd..fd49855a 100644
> --- a/drivers/platform/x86/thinkpad_acpi.c
> +++ b/drivers/platform/x86/thinkpad_acpi.c
> @@ -9611,7 +9611,11 @@ static const struct tpacpi_quirk battery_quirk_table[] __initconst = {
>          * Individual addressing is broken on models that expose the
>          * primary battery as BAT1.
>          */
> +       TPACPI_Q_LNV('J', '7', true),       /* B5400 */
> +       TPACPI_Q_LNV('J', 'I', true),       /* Thinkpad 11e */
> +       TPACPI_Q_LNV3('R', '0', 'B', true), /* Thinkpad 11e gen 3 */
>         TPACPI_Q_LNV3('R', '0', 'C', true), /* Thinkpad 13 */
> +       TPACPI_Q_LNV3('R', '0', 'J', true), /* Thinkpad 13 gen 2 */
>  };
>
>  static int __init tpacpi_battery_init(struct ibm_init_struct *ibm)
> --
> 2.18.0
>



-- 
With Best Regards,
Andy Shevchenko