Re: [ibm-acpi-devel] [PATCH v2] platform/x86: thinkpad_acpi: Fix multi-battery bug

[Andy S. <and...@gm...>]

On Thu, Aug 2, 2018 at 1:24 AM, Thomas Weißschuh <li...@we...> wrote:
> The struct containing the supported operations for all batteries is
> being zeroed on each battery probe.  This prevents all other batteries
> except the lastly probed one from being configured.

You forgot to include subsystem maintainers along with driver maintainer.

I pushed this to my review and testing queue, meanwhile I would wait
for Ack from Henrique.

>
> Signed-off-by: Thomas Weißschuh <li...@we...>
> ---
>
> Changes since v1:
>
> * Missing sign-off added
>
>  drivers/platform/x86/thinkpad_acpi.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c
> index 3dbff2dda9be..60de1c577ce0 100644
> --- a/drivers/platform/x86/thinkpad_acpi.c
> +++ b/drivers/platform/x86/thinkpad_acpi.c
> @@ -9374,7 +9374,9 @@ static int tpacpi_battery_probe(int battery)
>  {
>         int ret = 0;
>
> -       memset(&battery_info, 0, sizeof(struct tpacpi_battery_driver_data));
> +       memset(&battery_info.batteries[battery], 0,
> +               sizeof(battery_info.batteries[battery]));
> +
>         /*
>          * 1) Get the current start threshold
>          * 2) Check for support
> @@ -9616,6 +9618,8 @@ static const struct tpacpi_quirk battery_quirk_table[] __initconst = {
>
>  static int __init tpacpi_battery_init(struct ibm_init_struct *ibm)
>  {
> +       memset(&battery_info, 0, sizeof(battery_info));
> +
>         tp_features.battery_force_primary = tpacpi_check_quirks(
>                                         battery_quirk_table,
>                                         ARRAY_SIZE(battery_quirk_table));
> --
> 2.18.0
>



-- 
With Best Regards,
Andy Shevchenko