|
From: Andy S. <and...@gm...> - 2018-01-03 14:42:42
|
On Wed, Jan 3, 2018 at 1:59 PM, Ognjen Galic <smc...@gm...> wrote: > thinkpad_acpi registers two new attributes for each battery: > > 1) Charge start threshold > /sys/class/power_supply/BATN/charge_start_threshold > > Valid values are [0, 99]. A value of 0 turns off the > start threshold wear control. > > 2) Charge stop threshold > /sys/class/power_supply/BATN/charge_stop_threshold > > Valid values are [1, 100]. A value of 100 turns off > the stop threshold wear control. This must be > configured first. > > Signed-off-by: Ognjen Galic <smc...@gm...> Thanks for an update! > --- > > Notes: > * Change int to acpi_status in tpacpi_battery_acpi_eval Then you need to check return code with ACPI_FAILURE() or ACPI_SUCCESS() macros. That is one of the additional burden while I can't see usefulness of ACPI return codes in that function and why I suggested to use plain int. One more question: why don't you use dev_err()/dev_*() macros instead of pr_*() ones? (Note, it's a question, needs a bit of discussion, I would like to hear a rationale of this, I think it might be one) -- With Best Regards, Andy Shevchenko |
