|
From: Henrique de M. H. <hm...@hm...> - 2007-05-21 17:11:35
|
On Mon, 21 May 2007, Bastien Nocera wrote: > On Mon, 2007-05-21 at 13:37 +0100, Richard Hughes wrote: > > On Mon, 2007-05-21 at 09:26 -0300, Henrique de Moraes Holschuh wrote: > > > On Mon, 21 May 2007, Richard Hughes wrote: > > > > > You get full credits, of course, and I will wait an ACK from you before I > > > > > push it anywhere. It was your idea, and your patch probably is just fine as > > > > > far as "it works" goes, so you get to comment and offer suggestions before I > > > > > merge it. > > > > > > > > One comment I was about to make, are the INPUT events emitted even > > > > without a "echo enable,0xffff >/proc/acpi/ibm/hotkey"? > > > > > > No, they are not. > > > > Ick. > > Ick indeed. It should really be automatic (ie. no need to poke anywhere > to get the events back to user-space). No way, no how. The firmware often does better at it. > For the additional keys, I mentioned to Richard using "KEY_F13" and > above (really depending on the number of functions keys on those > keyboards), for keys which can't be easily mapped to existing keycodes. Not nice. It is not a KEY_F13, I am not going to map to it by default. What if someone plugs a USB keyboard that does have F13..F24 ? > X probably doesn't know about those keys, thus doesn't pass them on. We I was looking at the console, not X. I know X does filtering of its own. -- "One disk to rule them all, One disk to find them. One disk to bring them all and in the darkness grind them. In the Land of Redmond where the shadows lie." -- The Silicon Valley Tarot Henrique Holschuh |
