|
From: Dmitry T. <dt...@in...> - 2007-05-09 02:59:03
|
On Tuesday 08 May 2007 22:08, Henrique de Moraes Holschuh wrote: > The rfkill class has been merged in Linux mainline, and if at all possible, > thinkpad-acpi will use it to connect or disconnect the internal bluetooth > and WWAN devices. > > The rfkill class has a concept of "type" of the radio, which is used to, > e.g., turn on or off all radios of the same type. This is coupled to the > input subsystem, so that the kernel can switch on/off all radios of a given > type if KEY_WLAN or KEY_BLUETOOTH is pressed... (yes, I will add that to > thinkpad-acpi shortly). This behaviour can be overriden on a card-by-card > basis. > > Now, I can add a new WWAN type for the WWAN card, or I can group it with > WLAN. What I am *not* going to do is to request that KEY_WWAN be added to > the input subsystem, so if I add a new type, this means there will be no way > to bind (in kernel) a key to a WWAN radio on/off software switch, and the > usual scripts in userspace will be needed. > > It makes sense to group it with other WLAN rfkill switches, and thinkpads > only have a single key (typically fn+f5) which is supposed to control all > radios anyway, so I am inclined to do just that. > > Comments? > I would add a new switch type and adjust rfkill-input to toggle both WLAN and WWAN switches when user presses KEY_WLAN. More fine-grained control can be done in userspace. Does this make sense? -- Dmitry |
