Re: [ibm-acpi-devel] patch to add readonly support for T60 wireless killswitch

[Henning S. <he...@wh...>]

Am Sat, 24 Feb 2007 09:27:00 +0100
schrieb Henryk Pl=F6tz <he...@pl...>:

> Maintainers: Please include it in the mainline ibm-acpi.

I think it still needs some testing on other models with kill switch. I
do not know how to make ibm_acpi users test this. So far only the ones
on that list might have tested it. Maybe some like you who found that
patch looking for a way to read the switch state... I have feedback
that T42 and R51 do not have GSTS and WLSW DSTSs and do not have the
switch. And I know from the list that T43 does not have the switch but
i dont know whether it has one of the DSTS.
Maybe including it as experimental might be a good idea to get more
users to test it.

I was talking about WLSW which is (on T60) a method only returning GSTS.

        Scope (\_SB.PCI0.LPC.EC.HKEY)
        {
            Name (WGFL, 0x00)
            Method (WLSW, 0, NotSerialized)
            {
                Return (\_SB.PCI0.LPC.EC.GSTS)
            }

I do not know if it is correct to return GSTS or if it would be better
to use that getter. (maybe it returns some more/something else on other
models) I think using WLSW would be a more general way, but it makes no
difference for T60.

- if (!acpi_evalf(ec_handle, &state, "GSTS", "d")) {
+ if (!acpi_evalf(hkey_handle, &state, "WLSW", "d")) {

I wanted to extend hotkey_notify to generate different events (7000
and 7001) but i did not yet find where the 7000 comes from. That way
an acpi event handler would not have to check the state itsself.=20

Henning