|
From: Henrique de M. H. <hm...@hm...> - 2007-02-23 11:09:09
|
On Fri, 23 Feb 2007, Len Brown wrote: > +config ACPI_IBM_BAY > + bool "Legacy Removable Bay Support" > + depends on ACPI_IBM > + default y > + ---help--- > + Allows the ibm_acpi driver to handle removable bays. It will allow > + disabling the device in the bay, and also generate notifications when > + the bay lever is ejected or inserted. > + > + If you are not sure, say Y here. > + > > Why is the default Y? ACPI_BAY is still experimental, and breaks completely on ThinkPads if whatever is in the bay is not a disk (e.g. if it is a battery), at least during boot. Also, some thinkpads benefit from *optional* extra intelligence on bay handling during STR (which is not in ibm-acpi yet). E.g. a T43 can save a few watts if you power off whatever is in the bay right before STR, *as long as it is not a battery*. This is just an interim patch to let people easily disable ibm-acpi bay support. Another patch making it default to N and depend on !ACPI_BAY can be added later, but since I did not have a time window to work on ACPI_BAY + ibm-acpi interaction yet, I fear it is a little early for that. -- "One disk to rule them all, One disk to find them. One disk to bring them all and in the darkness grind them. In the Land of Redmond where the shadows lie." -- The Silicon Valley Tarot Henrique Holschuh |
