[ibm-acpi-devel] [PATCH 08/21] ACPI: ibm-acpi: break fan_read into separate functions

[Henrique de M. H. <hm...@hm...>]

From: Henrique de Moraes Holschuh <hm...@hm...>

This patch breaks fan_read mechanics into a generic function to get fan
status and speed, and leaves only the procfs interface code in fan_read.

Signed-off-by: Henrique de Moraes Holschuh <hm...@hm...>
---

 drivers/acpi/ibm_acpi.c |   78 ++++++++++++++++++++++++++++++++++++++++-=
------
 1 files changed, 66 insertions(+), 12 deletions(-)

diff --git a/drivers/acpi/ibm_acpi.c b/drivers/acpi/ibm_acpi.c
index ef8ac01..834485b 100644
--- a/drivers/acpi/ibm_acpi.c
+++ b/drivers/acpi/ibm_acpi.c
@@ -1738,36 +1738,90 @@ static int fan_init(void)
 	return 0;
 }
=20
-static int fan_read(char *p)
+static int fan_get_status(u8 *status)
 {
-	int len =3D 0;
-	u8 lo, hi, status;
+	u8 s;
=20
 	switch (fan_status_access_mode) {
 	case IBMACPI_FAN_RD_ACPI_GFAN:
 		/* 570, 600e/x, 770e, 770x */
-		if (unlikely(!acpi_evalf(gfan_handle, &status, NULL, "d")))
+
+		if (unlikely(!acpi_evalf(gfan_handle, &s, NULL, "d")))
 			return -EIO;
=20
-		len +=3D sprintf(p + len, "level:\t\t%d\n", status);
+		if (likely(status))
+			*status =3D s & 0x07;
=20
 		break;
=20
 	case IBMACPI_FAN_RD_TPEC:
 		/* all except 570, 600e/x, 770e, 770x */
-		if (unlikely(!acpi_ec_read(fan_status_offset, &status)))
+		if (unlikely(!acpi_ec_read(fan_status_offset, &s)))
 			return -EIO;
-		else
-			len +=3D sprintf(p + len, "status:\t\t%s\n",
-				       enabled(status, 7));
=20
+		if (likely(status))
+			*status =3D s;
+
+		break;
+
+	default:
+		return -ENXIO;
+	}
+
+	return 0;
+}
+
+static int fan_get_speed(unsigned int *speed)
+{
+	u8 hi, lo;
+
+	switch (fan_status_access_mode) {
+	case IBMACPI_FAN_RD_TPEC:
+		/* all except 570, 600e/x, 770e, 770x */
 		if (unlikely(!acpi_ec_read(fan_rpm_offset, &lo) ||
 			     !acpi_ec_read(fan_rpm_offset + 1, &hi)))
 			return -EIO;
-		else
-			len +=3D sprintf(p + len, "speed:\t\t%d\n",
-				       (hi << 8) + lo);
=20
+		if (likely(speed))
+			*speed =3D (hi << 8) | lo;
+
+		break;
+
+	default:
+		return -ENXIO;
+	}
+
+	return 0;
+}
+
+static int fan_read(char *p)
+{
+	int len =3D 0;
+	int rc;
+	u8 status;
+	unsigned int speed =3D 0;
+
+	switch (fan_status_access_mode) {
+	case IBMACPI_FAN_RD_ACPI_GFAN:
+		/* 570, 600e/x, 770e, 770x */
+		if ((rc =3D fan_get_status(&status)) < 0)
+			return rc;
+
+		len +=3D sprintf(p + len, "level:\t\t%d\n", status);
+
+		break;
+
+	case IBMACPI_FAN_RD_TPEC:
+		/* all except 570, 600e/x, 770e, 770x */
+		if ((rc =3D fan_get_status(&status)) < 0)
+			return rc;
+
+		len +=3D sprintf(p + len, "status:\t\t%s\n", enabled(status, 7));
+
+		if ((rc =3D fan_get_speed(&speed)) < 0)
+			return rc;
+
+		len +=3D sprintf(p + len, "speed:\t\t%d\n", speed);
 		break;
=20
 	case IBMACPI_FAN_NONE: